Re: [PR] feat(csharp/src/Drivers/BigQuery): Add support for overriding adbc.bigquery.large_decimals_as_string [arrow-adbc]

["CurtHagenlocher (via GitHub)" <gi...@apache.org>]

CurtHagenlocher commented on code in PR #3648:
URL: https://github.com/apache/arrow-adbc/pull/3648#discussion_r2500349422


##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -73,10 +73,19 @@ public BigQueryConnection(IReadOnlyDictionary<string, string> properties) : base
 
             TryInitTracerProvider(out _fileActivityListener);
 
-            // add the default value for now and set to true until C# has a BigDecimal
-            this.properties[BigQueryParameters.LargeDecimalsAsString] = BigQueryConstants.TreatLargeDecimalAsString;
             this.httpClient = new HttpClient();
 
+            // add the default value for now and set to true until C# has a BigDecimal

Review Comment:
   This comment looks stale now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org