You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "wjddn279 (via GitHub)" <gi...@apache.org> on 2026/06/07 12:42:53 UTC
[PR] Remove the structlog workaround and bump the version constraint [airflow]
wjddn279 opened a new pull request, #68168:
URL: https://github.com/apache/airflow/pull/68168
related: https://github.com/apache/airflow/pull/65121
As the `struclog` release the version (26.1.0, https://github.com/hynek/structlog/releases/tag/26.1.0) including the fix of the issue, remove the workaround and bump the version constraint
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove the structlog workaround and bump the version constraint [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #68168:
URL: https://github.com/apache/airflow/pull/68168#issuecomment-4644749347
waiting until `exclude-newer = "4 days"` and it maybe 6/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on code in PR #68168:
URL: https://github.com/apache/airflow/pull/68168#discussion_r3683426090
##########
shared/logging/pyproject.toml:
##########
@@ -26,7 +26,7 @@ classifiers = [
dependencies = [
"msgspec>=0.19.0",
"pygtrie>=2.5.0",
- "structlog>=25.4.0",
+ "structlog>=26.1.0",
Review Comment:
This landed on main earlier today as #70694, which bumps the same eight distributions to `structlog>=26.1.0` and removes the same `WRITE_LOCKS` monkeypatch from `configure_logging` along with the `import weakref`. Against main at 724aaade2f the remaining delta here is zero, so I think this can be closed. #70694 went a bit further and also raised `croniter` to 6.2.2 and dropped the `_BYTES_LOGGER_HAS_NAME` fallback that goes dead at the new structlog floor.
Apologies this sat for seven weeks after three approvals -- you spotted the fix first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround [airflow]
Posted by "wjddn279 (via GitHub)" <gi...@apache.org>.
wjddn279 commented on PR #68168:
URL: https://github.com/apache/airflow/pull/68168#issuecomment-4901769199
@ashb @amoghrajesh @uranusjr
I think it is ok to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil closed pull request #68168: Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround
URL: https://github.com/apache/airflow/pull/68168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump structlog to 26.1.0 and drop WRITE_LOCKS workaround [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #68168:
URL: https://github.com/apache/airflow/pull/68168#issuecomment-4689311616
I believe only the shared logging package’s dependency needs bumping. But it’s not a bad idea to keep everything in sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org