You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/10/10 23:52:20 UTC
[GitHub] flink pull request #2617: [FLINK-4705] Instrument FixedLengthRecordSorter
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2617
[FLINK-4705] Instrument FixedLengthRecordSorter
Updates comparators with support for key normalization.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 4705_instrument_fixedlengthrecordsorter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2617.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2617
----
commit 10d0955251ad9965da2094682ea1d4c468602373
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-09-28T16:55:03Z
[FLINK-4705] Instrument FixedLengthRecordSorter
Updates comparators with support for key normalization.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2617
I have started like to take a look at this...
The `FixLegthRecordSorter` and its interactions with the serializers / comparators was not very well tested before, hence not activated. I am trying to double-check that...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2617
@greghogan I am quite deep into some large scale deployment and scalability issues right now. I plan to write a mail to the mailing list on that, actually.
If possible, I'd like to defer this for a bit. I hope to find some time between the years to go over pull request and do catching up with these threads.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2617
Hi @StephanEwen, should we endeavor to get this into 1.2 or defer to the next release?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2617: [FLINK-4705] Instrument FixedLengthRecordSorter
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/2617
@StephanEwen, no worries about deferring this. Performance is nice but scaling and stability certainly takes precedence. Just wanted to make sure there was ample time between review and release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---