[GitHub] wu-sheng commented on a change in pull request #1975: update application.yml for namespace.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #1975: update application.yml for namespace.
URL: https://github.com/apache/incubator-skywalking/pull/1975#discussion_r237386485
 
 

 ##########
 File path: oap-server/server-starter/src/main/assembly/application.yml
 ##########
 @@ -59,6 +60,7 @@ storage:
 #    bulkSize: ${SW_STORAGE_ES_BULK_SIZE:20} # flush the bulk every 20mb
 #    flushInterval: ${SW_STORAGE_ES_FLUSH_INTERVAL:10} # flush the bulk every 10 seconds whatever the number of requests
 #    concurrentRequests: ${SW_STORAGE_ES_CONCURRENT_REQUESTS:2} # the number of concurrent requests
+#  mysql:
 
 Review comment:
   Yes. MySQL is based on the old setting file style, which is different. :) We could choose to move them into application.yml. 
   
   Anyway, that is another feature to discuss. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services