You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Colm Rice (JIRA)" <ji...@apache.org> on 2012/10/25 10:54:13 UTC
[jira] [Created] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Colm Rice created CODEC-161:
-------------------------------
Summary: Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
Key: CODEC-161
URL: https://issues.apache.org/jira/browse/CODEC-161
Project: Commons Codec
Issue Type: New Feature
Affects Versions: 1.6
Reporter: Colm Rice
Priority: Minor
I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
FYI: It my first contribution so be gentle :-) C# is my native.
I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA)
phonetic algorithm encoder
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505787#comment-13505787 ]
Gary Gregory commented on CODEC-161:
------------------------------------
I did not notice your new patch, sorry about that. I'll take a look tonight.
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495423#comment-13495423 ]
Thomas Neidhart commented on CODEC-161:
---------------------------------------
Hi Colm,
thanks for the update, but the patch is rather empty, could you please check and re-upload?
Thanks,
Thomas
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495657#comment-13495657 ]
Gary Gregory commented on CODEC-161:
------------------------------------
Hi Colm,
My comments are the same, see above: https://issues.apache.org/jira/browse/CODEC-161?focusedCommentId=13485148&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13485148
I've not gone through to see if you've addresses any of comments but a quick scan shows that you did not pick up 2 and 3 so I'll wait for the next version of the patch ;)
Thank you,
Gary
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CODEC-161) Add Match Rating Approach (MRA)
phonetic algorithm encoder
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory resolved CODEC-161.
--------------------------------
Resolution: Fixed
Fix Version/s: 1.8
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Fix For: 1.8
>
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CODEC-161) Add phonetic algorithm Match
Rating Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484828#comment-13484828 ]
Colm Rice edited comment on CODEC-161 at 10/26/12 10:20 AM:
------------------------------------------------------------
MRA phonetic codec patch. My 1st contribution :-)
Ack. Ryan McKinley cf. LUCENE-4494
was (Author: crice):
MRA patch. My 1st contribution :-)
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505655#comment-13505655 ]
Colm Rice commented on CODEC-161:
---------------------------------
Hi everyone, just wondering is there any movement on this :-)
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-161) Add Match Rating Approach (MRA)
phonetic algorithm encoder
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary Gregory updated CODEC-161:
-------------------------------
Summary: Add Match Rating Approach (MRA) phonetic algorithm encoder (was: Add phonetic algorithm Match Rating Approach (MRA) to the commons codec)
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496073#comment-13496073 ]
Colm Rice commented on CODEC-161:
---------------------------------
Hi Thomas/Gary,
I knew there was something fishy :-) When I pump out "svn diff" to the patch file its not picking up the improvements I've made to the files located at:
/LuceneCodec/main/java/org/apache/commons/codec/language
I'll look into it asap.
Thanks,
Colm
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485138#comment-13485138 ]
Thomas Neidhart commented on CODEC-161:
---------------------------------------
Hi Colm,
thanks for your contribution, I looked at the patch and it's not so bad, though it will require some adaptations before it can be accepted:
* indentation is normally 4 chars, only spaces
* author name is usually omitted in the source files, but added to the pom.xml
* try to avoid trailing spaces in a line
* naming convention for methods: camel case, e.g. removeVowels, instead of RemoveVowels
* try to use parenthesis also for single line if clauses
* documentation for private methods should be using javadoc style or omitted
* the removeAccents method uses indexOf in a string to remove accents, but this can be rather slow for large strings
better use a set of all accent chars
btw. there is a checkstyle configuration in the trunk, which you can use to check your contribution (e.g. with the eclipse plugin or on the command line with maven: mvn checkstyle:checkstyle). The less warnings remain the more likely it is that a patch will be committed ;-).
Thomas
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm Rice updated CODEC-161:
----------------------------
Attachment: CODEC-161-MatchRatingApproach.patch
MRA patch. My 1st contribution :-)
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm Rice updated CODEC-161:
----------------------------
Attachment: CODEC-161.patch
Match Rating Approach encoder & tests I think. Post code-review.
I have a funny feeling I've done something wrong :-)
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13488272#comment-13488272 ]
Colm Rice commented on CODEC-161:
---------------------------------
Hi Thomas/Gary,
Thanks a mill for the code review. I'm such a newbie I was actually unaware of the trunk checkstyle config :-) Nice! Will use going forward. BTW, I'm using the Eclipse IDE - let me know of any other tips/plugins that are useful. C# is my native, so I'm crossing over a bit into Java.
I will of course re-factor your suggestions.
TBC,
Colm
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485148#comment-13485148 ]
Gary Gregory commented on CODEC-161:
------------------------------------
Hello Colm,
Thank you for the patch. Welcome to our little [codec] world!
Please find my code review below.
# General note: Look at the code around you in [codec] and follow the conventions you see.
# Rename the main class from {{MatchRatingApproach}} to {{MatchRatingApproachEncoder}}
# All methods start with a lower case, so rename {{public static String GetMRA(String name)}} to {{GetMRA}}, and so on.
# About @see hyperlink(s) in the Javadoc for {{MatchRatingApproachEncoder}}. If Wikipedia is all there is, then so be it, but any other documentation would be helpful.
# You can add yourself as a contributor in the pom.xml but I'd rather leave names, emails (and egos) out of .java files.
# In the Javadocs, "soundex" should be "Soundex".
# Always use blocks. IOW: if (expr){\n stmt;\n}
# Rename all unit test methods to be prefixed with {{test}} instead of {{MRA_}}.
# The method {{RemoveDoubleConsonants}} (sic) looks like it could be implemented in one loop. I'd worry about this one last.
# {{PLAIN_ASCII}} and {{UNICODE}} need Javadoc to explain how they are used.
# Rename {{MatchRatingApproachTests}} to {{MatchRatingApproachTest}} (singular) or Maven will not pick it up in the test suite.
# Improve code coverage from 84% to... can you get it to 100%?
# In-line your test methods from:
{code:java}
@Test
public void MRA_Compare_ZACH_ZAKARIA_SuccessfullyMatched()
{
//Arrange
String testInput2 = "Zach";
String testInput1 = "Zakaria";
//Assert
boolean actualRes = MatchRatingApproach.CompareMRA(testInput1, testInput2);
//Act
assertTrue(actualRes);
}
{code}
to:
{code:java}
@Test
public void MRA_Compare_ZACH_ZAKARIA_SuccessfullyMatched() {
assertTrue(MatchRatingApproach.CompareMRA("Zakaria", "Zach"));
}
{code}
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Colm Rice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colm Rice updated CODEC-161:
----------------------------
Attachment: CODEC-161.patch
This looks a bit better. Fingers crossed... :-)
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add phonetic algorithm Match Rating
Approach (MRA) to the commons codec
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484052#comment-13484052 ]
Gary Gregory commented on CODEC-161:
------------------------------------
Ok, you'll need to add the patch here.
> Add phonetic algorithm Match Rating Approach (MRA) to the commons codec
> -----------------------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA)
phonetic algorithm encoder
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505887#comment-13505887 ]
Gary Gregory commented on CODEC-161:
------------------------------------
The patch is in with much further tweaking. Thank you.
{noformat}
commit -m "<action dev="ggregory" type="add" issue="CODEC-161" due-to="crice">Add Match Rating Approach (MRA) phonetic algorithm encoder.</action>" C:/svn/org/apache/commons/trunks-proper/codec/pom.xml C:/svn/org/apache/commons/trunks-proper/codec/src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java C:/svn/org/apache/commons/trunks-proper/codec/src/changes/changes.xml C:/svn/org/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Sending C:/svn/org/apache/commons/trunks-proper/codec/pom.xml
Sending C:/svn/org/apache/commons/trunks-proper/codec/src/changes/changes.xml
Adding C:/svn/org/apache/commons/trunks-proper/codec/src/main/java/org/apache/commons/codec/language/MatchRatingApproachEncoder.java
Adding C:/svn/org/apache/commons/trunks-proper/codec/src/test/java/org/apache/commons/codec/language/MatchRatingApproachEncoderTest.java
Transmitting file data ...
Committed revision 1414916.
{noformat}
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Fix For: 1.8
>
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CODEC-161) Add Match Rating Approach (MRA)
phonetic algorithm encoder
Posted by "Gary Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CODEC-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505901#comment-13505901 ]
Gary Gregory commented on CODEC-161:
------------------------------------
Colm,
Please review my version, there should be no behavior changes. All the tests still pass of course.
Also see if you can improve the code coverage.
Thank you!
Gary
> Add Match Rating Approach (MRA) phonetic algorithm encoder
> ----------------------------------------------------------
>
> Key: CODEC-161
> URL: https://issues.apache.org/jira/browse/CODEC-161
> Project: Commons Codec
> Issue Type: New Feature
> Affects Versions: 1.6
> Reporter: Colm Rice
> Priority: Minor
> Labels: newbie
> Fix For: 1.8
>
> Attachments: CODEC-161-MatchRatingApproach.patch, CODEC-161.patch, CODEC-161.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> I want to add MatchRatingApproach algorithm to the Lucene project via commons codec.
> What I have at the moment is a class called org.apache.lucene.analysis.phoenetic.MatchRatingApproach implementing StringEncoder
> I have a pretty comprehensive test file located at: org.apache.lucene.analysis.phonetic.MatchRatingApproachTests
> It's not exactly existing pattern so I'm going to need a bit of advice here. Thanks! Feel free to email.
> FYI: It my first contribution so be gentle :-) C# is my native.
> I had incorrectly added this to Lucene solution as LUCENE-4494 but received some good advice to move it to here. I'm doing that now.
> Reference: http://en.wikipedia.org/wiki/Match_rating_approach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira