You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/09/20 22:37:19 UTC
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14276
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
---
M docs/topics/impala_webui.xml
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/14276/1
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/492/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:31:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14276/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/14276/1/docs/topics/impala_webui.xml@611
PS1, Line 611: text or Json
Also thrift
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:22:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/492/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:41:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/491/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 22:37:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Jiawei Wang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14276
to look at the new patch set (#2).
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
---
M docs/topics/impala_webui.xml
1 file changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/14276/2
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/491/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 22:59:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 1:
Please address the comment about thrift profile.
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:22:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Reviewed-on: http://gerrit.cloudera.org:8080/14276
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_webui.xml
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Michael Ho: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14276/1/docs/topics/impala_webui.xml
File docs/topics/impala_webui.xml:
http://gerrit.cloudera.org:8080/#/c/14276/1/docs/topics/impala_webui.xml@611
PS1, Line 611: text or Json
> Also thrift
Done
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:32:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8878: [DOCS] Query profile export to Json in WebUI
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/14276 )
Change subject: IMPALA-8878: [DOCS] Query profile export to Json in WebUI
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14276
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10249f0019f51d8f6511ce2c2436f56a33099967
Gerrit-Change-Number: 14276
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jiawei Wang <ji...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Sep 2019 23:33:40 +0000
Gerrit-HasComments: No