[GitHub] spark pull request #15593: [SPARK-18060][ML] Avoid unnecessary computation f...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15593#discussion_r86420744
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -489,13 +485,14 @@ class LogisticRegression @Since("1.2.0") (
               val initialCoefWithInterceptArray = initialCoefficientsWithIntercept.toArray
               val providedCoef = optInitialModel.get.coefficientMatrix
               providedCoef.foreachActive { (row, col, value) =>
    -            val flatIndex = row * numFeaturesPlusIntercept + col
    +            // convert matrix to column major for training
    --- End diff --
    
    Is this code path ever tested? Since the current `initialModel` is just a sort of dummy placeholder, always `None`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org