You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/10 08:46:59 UTC

[PR] [SPARK-58690][CORE] Fix typos in storage package comments [spark]

uros-b opened a new pull request, #57891:
URL: https://github.com/apache/spark/pull/57891

   ### What changes were proposed in this pull request?
   
   Fixes four comment typos under `core/src/main/scala/org/apache/spark/storage/`:
   
   - `BlockInfoManager`: `Helper for lock acquisistion` to `acquisition`
   - `BlockManagerMasterEndpoint`: `broadcasts the serialized mapstatues` to `map statuses`
   - `ShuffleBlockFetcherIterator`: `The exception could only be throwed by` to `thrown`
   - `ShuffleBlockFetcherIterator`: `push-merged shuffle files are storedl` to `stored`
   
   ### Why are the changes needed?
   
   Each is a plain misspelling, and each is the only occurrence of that spelling in the repository. On the second one, the surrounding comment consistently wraps code identifiers in backticks (`` `MapOutputTracker.serializeOutputStatuses` ``, `` `updateMapOutput` ``), so the intent is the English plural rather than the `mapStatuses` field, and it is rendered as two words accordingly.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Comment text only, with no effect on compiled code. Each edited line was confirmed to sit inside a scaladoc or `//` comment, and no identifier, string literal, or error message is touched. The longest resulting line is 97 characters, within the limit.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code (Opus 4.8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58690][CORE] Fix typos in storage package comments [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57891:
URL: https://github.com/apache/spark/pull/57891#issuecomment-5329723415

   Thank you @arunkarthike and @dongjoon-hyun!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58690][CORE] Fix typos in storage package comments [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57891: [SPARK-58690][CORE] Fix typos in storage package comments
URL: https://github.com/apache/spark/pull/57891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-58690][CORE] Fix typos in storage package comments [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57891:
URL: https://github.com/apache/spark/pull/57891#issuecomment-5329737362

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/6c24c560392c7f7fda56e75cc5e003b5af4fd358
   - merged into branch-4.x https://github.com/apache/spark/commit/658a23cbf4e75a64e005dc2b60257f25fa38d9ba
   - merged into branch-4.3 https://github.com/apache/spark/commit/cb7db40c71b2345f211369fdc07f549683af6722
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org