Re: [PR] Update org.apache.hadoop:* to v3.4.0 [solr]

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on PR #2380:
URL: https://github.com/apache/solr/pull/2380#issuecomment-2237235859

   Created a JIRA SOLR-17374 for this
   
   There were two new jar requirements: `jline` and `jsch`. Looks like both are only test deps related to parsing user input and executing hadoop tasks over ssh, so I'll exclude them from the build. (1e6b480ffe235aa0b4f3a4e0f2602d21dbcc89f4)
   
   Java level changes:
   * New signature for `ReplicaMap` constructor, where I replace `new ReplicaMap(new ReentrantReadWriteLock())` with `new ReplicaMap(new DataSetLockManager())`. (7948541241edb24a52b439039679a1bd9fe97bf8)
   * Use `IOUtils.cleanupWithLogger` instead of deprecated `IOUtils.cleanup` (55f1dcef20d305b2a89e7338e9377c047d370338)
   * Remove a new unused dependency `org.slf4j:jcl-over-slf4j:2.0.13@jar` (8dfcc64049efa5e0bde06678d4d338331515a351)
   
   Very happy for some review on these changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org