You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Suma Shivaprasad <su...@gmail.com> on 2017/02/22 02:09:05 UTC
Review Request 56910: Fix issues with owned map reference and add
tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/
-----------------------------------------------------------
Review request for atlas.
Bugs: ATLAS-1584
https://issues.apache.org/jira/browse/ATLAS-1584
Repository: atlas
Description
-------
Fixed map model validation and added tests for map
Diffs
-----
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 555f0ac
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 845bbb4
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77
Diff: https://reviews.apache.org/r/56910/diff/
Testing
-------
Thanks,
Suma Shivaprasad
Re: Review Request 56910: Fix issues with owned map reference and add
tests
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/#review166346
-----------------------------------------------------------
Ship it!
- Vimal Sharma
On Feb. 22, 2017, 2:09 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56910/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 2:09 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1584
> https://issues.apache.org/jira/browse/ATLAS-1584
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fixed map model validation and added tests for map
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 555f0ac
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 845bbb4
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77
>
> Diff: https://reviews.apache.org/r/56910/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56910: Fix issues with owned map reference and add
tests
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/#review166342
-----------------------------------------------------------
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java (line 814)
<https://reviews.apache.org/r/56910/#comment238286>
Can we add an assertion here to check whether the mapValueGuid(using mapOwner attributes) is equal to guid in vertex obtained in line 813
- Vimal Sharma
On Feb. 22, 2017, 2:09 a.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56910/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2017, 2:09 a.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1584
> https://issues.apache.org/jira/browse/ATLAS-1584
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fixed map model validation and added tests for map
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 555f0ac
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 845bbb4
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77
>
> Diff: https://reviews.apache.org/r/56910/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56910: Fix issues with owned map reference and add
tests
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/#review167013
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala (line 320)
<https://reviews.apache.org/r/56910/#comment239117>
This file seems to have only white-space changes. Please review.
- Madhan Neethiraj
On Feb. 23, 2017, 7:31 p.m., Suma Shivaprasad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56910/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 7:31 p.m.)
>
>
> Review request for atlas.
>
>
> Bugs: ATLAS-1584
> https://issues.apache.org/jira/browse/ATLAS-1584
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fixed map model validation and added tests for map
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106
> intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 49d5a08
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 09f69db
> repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 3a310a7
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 555f0ac
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 845bbb4
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77
>
> Diff: https://reviews.apache.org/r/56910/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Suma Shivaprasad
>
>
Re: Review Request 56910: Fix issues with owned map reference and add
tests
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56910/
-----------------------------------------------------------
(Updated Feb. 23, 2017, 7:31 p.m.)
Review request for atlas.
Changes
-------
Fixed tests
Bugs: ATLAS-1584
https://issues.apache.org/jira/browse/ATLAS-1584
Repository: atlas
Description
-------
Fixed map model validation and added tests for map
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 57ad106
intg/src/test/java/org/apache/atlas/TestUtilsV2.java 84e17cb
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 49d5a08
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java 09f69db
repository/src/main/scala/org/apache/atlas/query/GremlinQuery.scala 3a310a7
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasDeleteHandlerV1Test.java 555f0ac
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1Test.java 845bbb4
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/HardDeleteHandlerV1Test.java fd685c6
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/SoftDeleteHandlerV1Test.java eba9c77
Diff: https://reviews.apache.org/r/56910/diff/
Testing
-------
Thanks,
Suma Shivaprasad