[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5333: vmware: delete snapshot disk after backup to secondary storage

[GitBox <gi...@apache.org>]

harikrishna-patnala commented on a change in pull request #5333:
URL: https://github.com/apache/cloudstack/pull/5333#discussion_r691848684



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
##########
@@ -2025,7 +2025,6 @@ public Answer backupSnapshot(CopyCommand cmd) {
                 try {
                     if (workerVm != null) {
                         // detach volume and destroy worker vm
-                        workerVm.detachAllDisks();

Review comment:
       verified the issue and is reproducible. We need to delete the cloned VM completely including disks, not the worker VM (worker VM has the actual disk attached to it). Also there is another place to fix. I'll fix and update this PR. Thanks @rhtyd for drafting this PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org