[GitHub] clintropolis commented on issue #6397: Adds bloom filter aggregator to 'druid-bloom-filters' extension

[GitBox <gi...@apache.org>]

clintropolis commented on issue #6397: Adds bloom filter aggregator to 'druid-bloom-filters' extension
URL: https://github.com/apache/incubator-druid/pull/6397#issuecomment-452540941
 
 
   @dclim, @leventov (and anyone else interested) I think this PR is ready for review again. I think I've addressed all existing comments via code changes, apologies for the rebases - I jumped the gun a bit opening this before the rest of the bloom filter extension had stabilized. 
   
   I've also added a bunch of methods to our copy of the Hive BloomKFilter to enable in situ manipulation of BloomKFilters that are serialized into a ByteBuffer, to allow much more memory efficient buffer aggs, which I will attempt to get pushed to the upstream implementation soon to avoid diverging too much. Additionally the documentation has been improved a bit for the extension, and have simplified the code where possible in response to comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org