You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/09/25 20:22:25 UTC
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Mike Percy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11510
Change subject: java: improve assertion failure message in TestAsyncKuduSession.test
......................................................................
java: improve assertion failure message in TestAsyncKuduSession.test
This test is fairly flaky (tracked in KUDU-1521) and while I don't have
time to fix the underlying issue I want to make it easier to track this
in the future. Instead of just throwing a base AssertionError, it will
now throw an error indicating that it failed because it was expecting a
PleaseThrottleException that never appeared.
Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11510/1
--
To view, visit http://gerrit.cloudera.org:8080/11510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Gerrit-Change-Number: 11510
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11510 )
Change subject: java: improve assertion failure message in TestAsyncKuduSession.test
......................................................................
Patch Set 1: Verified+1
overriding unrelated flaky test failure
--
To view, visit http://gerrit.cloudera.org:8080/11510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Gerrit-Change-Number: 11510
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 25 Sep 2018 21:42:08 +0000
Gerrit-HasComments: No
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11510 )
Change subject: java: improve assertion failure message in TestAsyncKuduSession.test
......................................................................
java: improve assertion failure message in TestAsyncKuduSession.test
This test is fairly flaky (tracked in KUDU-1521) and while I don't have
time to fix the underlying issue I want to make it easier to track this
in the future. Instead of just throwing a base AssertionError, it will
now throw an error indicating that it failed because it was expecting a
PleaseThrottleException that never appeared.
Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Reviewed-on: http://gerrit.cloudera.org:8080/11510
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Mike Percy: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Gerrit-Change-Number: 11510
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has removed a vote on this change.
Change subject: java: improve assertion failure message in TestAsyncKuduSession.test
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Gerrit-Change-Number: 11510
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] java: improve assertion failure message in TestAsyncKuduSession.test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11510 )
Change subject: java: improve assertion failure message in TestAsyncKuduSession.test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11510
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Gerrit-Change-Number: 11510
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 25 Sep 2018 20:24:24 +0000
Gerrit-HasComments: No