You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "wenzhenghu (via GitHub)" <gi...@apache.org> on 2025/05/03 07:42:29 UTC
[PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
wenzhenghu opened a new pull request, #50584:
URL: https://github.com/apache/doris/pull/50584
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2849010014
<details>
<summary>ClickBench: <b>Total hot run time: 28.74 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9af32f2bcbd5b48440726f22ae8ac80c559c31bb, data reload: false
query1 0.04 0.04 0.03
query2 0.12 0.11 0.12
query3 0.28 0.19 0.20
query4 1.60 0.20 0.20
query5 0.58 0.58 0.57
query6 1.18 0.72 0.72
query7 0.03 0.02 0.02
query8 0.05 0.03 0.03
query9 0.57 0.51 0.51
query10 0.56 0.58 0.56
query11 0.15 0.11 0.11
query12 0.15 0.11 0.12
query13 0.61 0.59 0.59
query14 0.81 0.79 0.81
query15 0.86 0.85 0.85
query16 0.38 0.38 0.38
query17 1.02 1.04 1.01
query18 0.21 0.20 0.20
query19 1.90 1.89 1.81
query20 0.02 0.00 0.01
query21 15.39 0.88 0.53
query22 0.76 1.09 0.63
query23 15.08 1.37 0.64
query24 7.20 1.40 0.44
query25 0.49 0.16 0.26
query26 0.66 0.16 0.13
query27 0.06 0.06 0.05
query28 9.21 0.94 0.42
query29 12.56 3.89 3.25
query30 0.26 0.09 0.07
query31 2.81 0.59 0.37
query32 3.24 0.55 0.46
query33 2.97 3.06 3.03
query34 15.82 5.01 4.48
query35 4.49 4.52 4.49
query36 0.66 0.49 0.48
query37 0.08 0.06 0.06
query38 0.05 0.04 0.04
query39 0.03 0.03 0.02
query40 0.18 0.14 0.12
query41 0.08 0.03 0.03
query42 0.03 0.02 0.03
query43 0.04 0.03 0.03
Total cold run time: 103.27 s
Total hot run time: 28.74 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2849049544
# BE Regression && UT Coverage Report
Increment line coverage `71.43% (5/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/50584_9af32f2bcbd5b48440726f22ae8ac80c559c31bb_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/50584_9af32f2bcbd5b48440726f22ae8ac80c559c31bb_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.28% (21328/26568) |
| Line Coverage | 74.37% (220129/295979) |
| Region Coverage | 72.69% (132437/182202) |
| Branch Coverage | 66.02% (67715/102568) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2849004897
<details>
<summary>TPC-H: <b>Total hot run time: 33631 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9af32f2bcbd5b48440726f22ae8ac80c559c31bb, data reload: false
------ Round 1 ----------------------------------
q1 26087 4985 4963 4963
q2 2071 279 174 174
q3 10387 1245 706 706
q4 10221 975 506 506
q5 7550 2308 2298 2298
q6 179 162 135 135
q7 907 744 631 631
q8 9313 1231 989 989
q9 6769 5144 5082 5082
q10 6799 2289 1903 1903
q11 472 290 268 268
q12 348 352 220 220
q13 17760 3677 3080 3080
q14 220 223 210 210
q15 520 486 475 475
q16 421 423 374 374
q17 572 838 347 347
q18 7444 7206 7109 7109
q19 1233 940 552 552
q20 340 333 215 215
q21 3709 2696 2427 2427
q22 1043 1016 967 967
Total cold run time: 114365 ms
Total hot run time: 33631 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5048 4975 5042 4975
q2 231 322 231 231
q3 2144 2613 2323 2323
q4 1352 1784 1339 1339
q5 4276 4304 4367 4304
q6 221 176 128 128
q7 1968 1910 1766 1766
q8 2528 2501 2539 2501
q9 7129 7163 6989 6989
q10 2965 3186 2713 2713
q11 592 508 507 507
q12 643 766 595 595
q13 3533 3907 3286 3286
q14 297 290 283 283
q15 510 501 463 463
q16 459 504 463 463
q17 1135 1497 1368 1368
q18 7698 7473 7347 7347
q19 785 846 891 846
q20 1959 2029 1882 1882
q21 5091 4673 4591 4591
q22 1101 1086 1032 1032
Total cold run time: 51665 ms
Total hot run time: 49932 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2848992781
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2848489221
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2848993040
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2849008292
<details>
<summary>TPC-DS: <b>Total hot run time: 192544 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9af32f2bcbd5b48440726f22ae8ac80c559c31bb, data reload: false
query1 1385 1115 1066 1066
query2 6275 1883 1885 1883
query3 10976 4647 4559 4559
query4 55394 26158 23012 23012
query5 5059 550 479 479
query6 347 214 206 206
query7 4893 511 283 283
query8 311 275 239 239
query9 5550 2601 2595 2595
query10 419 331 281 281
query11 15016 15392 14886 14886
query12 169 112 107 107
query13 1056 523 391 391
query14 10192 6452 6271 6271
query15 208 201 183 183
query16 7163 676 492 492
query17 1079 759 616 616
query18 1625 430 357 357
query19 201 191 175 175
query20 128 129 126 126
query21 205 125 110 110
query22 4323 4476 4279 4279
query23 34244 33448 33448 33448
query24 7055 2446 2427 2427
query25 458 471 405 405
query26 689 287 157 157
query27 2160 510 338 338
query28 3110 2141 2140 2140
query29 588 584 446 446
query30 278 226 193 193
query31 890 841 805 805
query32 73 66 65 65
query33 456 369 337 337
query34 774 842 529 529
query35 818 837 746 746
query36 949 1015 906 906
query37 107 97 78 78
query38 4124 4319 4154 4154
query39 1545 1442 1502 1442
query40 216 136 106 106
query41 54 54 52 52
query42 128 115 112 112
query43 535 520 504 504
query44 1354 846 828 828
query45 194 173 180 173
query46 904 1045 654 654
query47 1829 1856 1755 1755
query48 398 437 314 314
query49 686 546 434 434
query50 663 686 407 407
query51 4172 4206 4146 4146
query52 118 117 101 101
query53 230 257 188 188
query54 598 591 526 526
query55 87 86 87 86
query56 331 312 290 290
query57 1180 1202 1165 1165
query58 264 257 261 257
query59 2834 2873 2764 2764
query60 343 332 310 310
query61 136 132 126 126
query62 728 753 702 702
query63 228 195 198 195
query64 1752 1030 676 676
query65 4333 4243 4242 4242
query66 731 401 308 308
query67 15996 15782 15180 15180
query68 7668 881 536 536
query69 533 317 271 271
query70 1174 1050 1122 1050
query71 503 319 282 282
query72 5830 4724 4749 4724
query73 1497 636 351 351
query74 9290 9279 8939 8939
query75 3817 3220 2660 2660
query76 4123 1204 856 856
query77 651 376 284 284
query78 10126 9944 9290 9290
query79 5534 761 558 558
query80 800 497 444 444
query81 488 255 213 213
query82 561 130 96 96
query83 345 251 239 239
query84 291 104 79 79
query85 776 397 318 318
query86 385 313 300 300
query87 4615 4387 4274 4274
query88 3702 2227 2237 2227
query89 441 305 285 285
query90 1825 209 218 209
query91 144 138 110 110
query92 75 61 58 58
query93 3687 918 572 572
query94 667 410 305 305
query95 367 295 286 286
query96 470 573 274 274
query97 3171 3224 3147 3147
query98 227 207 197 197
query99 1456 1396 1297 1297
Total cold run time: 306553 ms
Total hot run time: 192544 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2848993054
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] 1. use correct curr_size value for filecache statistics in BlockFileCache::get_stats. 2. add warning if total size of cache is ilegal [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #50584:
URL: https://github.com/apache/doris/pull/50584#issuecomment-2849025878
# BE UT Coverage Report
Increment line coverage `28.57% (2/7)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/9af32f2bcbd5b48440726f22ae8ac80c559c31bb_9af32f2bcbd5b48440726f22ae8ac80c559c31bb/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/9af32f2bcbd5b48440726f22ae8ac80c559c31bb_9af32f2bcbd5b48440726f22ae8ac80c559c31bb/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 55.02% (14894/27069) |
| Line Coverage | 44.16% (130937/296491) |
| Region Coverage | 42.83% (66714/155759) |
| Branch Coverage | 37.38% (33638/89990) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](file cache) Fix BlockFileCache::get_stats [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #50584:
URL: https://github.com/apache/doris/pull/50584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org