You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/24 07:34:23 UTC
[GitHub] [spark] beliefer opened a new pull request, #37644: [SPARK-40203][SQL] Add test cases for Spark Decimal
beliefer opened a new pull request, #37644:
URL: https://github.com/apache/spark/pull/37644
### What changes were proposed in this pull request?
Recently, I find that some operators of Spark Decimal missing unit tests. e.g. quot, negate, abs, floor, ceil.
This PR adds test cases for these operators of Spark Decimal missing unit tests.
### Why are the changes needed?
Spark Decimal have a lot of methods without unit tests.
### Does this PR introduce _any_ user-facing change?
'No'.
Just add test cases.
### How was this patch tested?
New test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #37644: [SPARK-40203][SQL][TESTS] Add test cases for Decimal
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #37644: [SPARK-40203][SQL][TESTS] Add test cases for Decimal
URL: https://github.com/apache/spark/pull/37644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #37644: [SPARK-40203][SQL] Add test cases for Spark Decimal
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37644:
URL: https://github.com/apache/spark/pull/37644#issuecomment-1225316043
ping @MaxGekk @gengliangwang @dongjoon-hyun @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #37644: [SPARK-40203][SQL][TESTS] Add test cases for Decimal
Posted by GitBox <gi...@apache.org>.
beliefer commented on PR #37644:
URL: https://github.com/apache/spark/pull/37644#issuecomment-1225644619
@MaxGekk Thank you very much !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #37644: [SPARK-40203][SQL][TESTS] Add test cases for Decimal
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #37644:
URL: https://github.com/apache/spark/pull/37644#issuecomment-1225638924
+1, LGTM. Merging to master.
Thank you, @beliefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org