You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by "DomGarguilo (via GitHub)" <gi...@apache.org> on 2023/03/03 15:47:14 UTC

[GitHub] [accumulo] DomGarguilo commented on pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream

DomGarguilo commented on PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#issuecomment-1453728229

   > It seems to me that we should probably synchronizing around the code that uses or modifies the `cur` pointer, to fix that, which is a whole different thing than merely making it volatile.
   
   It seems like synchronization was intentionally avoided here for some reason. The comment at the top mentions avoiding synchronization. 
   https://github.com/apache/accumulo/blob/fe31930ccef448a549cea082943c510b678dbecd/core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java#L28-L31


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org