[GitHub] [lucene] romseygeek commented on pull request #148: Make ConjunctionDISI package-private and add ConjunctionUtils factory class

[GitBox <gi...@apache.org>]

romseygeek commented on pull request #148:
URL: https://github.com/apache/lucene/pull/148#issuecomment-847079159


   > It looks like spans just also use the new (public) ConjunctionUtils, which provide (safe) public access to the package-private ConjunctionDISI?
   
   Unfortunately no, if we do this then Spans don't use two-phase iteration any more.  What might work instead though would be to make `ConjunctionDISI.createConjunction(List<DocIdSetIterator>,List<TwoPhaseIterator>)` public through `ConjunctionUtils` - I'll give that a try and report back!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org