You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by sf...@apache.org on 2010/04/05 23:17:12 UTC
svn commit: r930962 - in /httpd/httpd/trunk: modules/ldap/util_ldap.c
server/util_expr.c
Author: sf
Date: Mon Apr 5 21:17:08 2010
New Revision: 930962
URL: http://svn.apache.org/viewvc?rev=930962&view=rev
Log:
fix more errors found by cppcheck
Modified:
httpd/httpd/trunk/modules/ldap/util_ldap.c
httpd/httpd/trunk/server/util_expr.c
Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?rev=930962&r1=930961&r2=930962&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
+++ httpd/httpd/trunk/modules/ldap/util_ldap.c Mon Apr 5 21:17:08 2010
@@ -231,10 +231,12 @@ static apr_status_t uldap_connection_cle
*/
static apr_status_t util_ldap_connection_remove (void *param) {
util_ldap_connection_t *ldc = param, *l = NULL, *prev = NULL;
- util_ldap_state_t *st = ldc->st;
+ util_ldap_state_t *st;
if (!ldc) return APR_SUCCESS;
+ st = ldc->st;
+
uldap_connection_unbind(ldc);
#if APR_HAS_THREADS
Modified: httpd/httpd/trunk/server/util_expr.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_expr.c?rev=930962&r1=930961&r2=930962&view=diff
==============================================================================
--- httpd/httpd/trunk/server/util_expr.c (original)
+++ httpd/httpd/trunk/server/util_expr.c Mon Apr 5 21:17:08 2010
@@ -44,7 +44,7 @@
} while(0)
#define CREATE_NODE(pool,name) do { \
- (name) = apr_pcalloc(pool, sizeof(*(name)));
+ (name) = apr_pcalloc(pool, sizeof(*(name))); \
} while(0)
static void debug_printf(request_rec *r, const char *fmt, ...)