You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Bastian Hofmann <ba...@googlemail.com> on 2011/04/03 18:12:04 UTC
Review Request: PHP: View level support for Features, Preloads and Locales
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/545/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
See https://issues.apache.org/jira/browse/SHINDIG-1521 and http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
Diffs
-----
/trunk/php/src/gadgets/Gadget.php 1088245
/trunk/php/src/gadgets/GadgetFactory.php 1088245
/trunk/php/src/gadgets/GadgetSpecParser.php 1088245
/trunk/php/test/gadgets/GadgetFactoryTest.php 1088245
/trunk/php/test/gadgets/GadgetTest.php 1088245
Diff: https://reviews.apache.org/r/545/diff
Testing
-------
Thanks,
Bastian
Re: Review Request: PHP: View level support for Features,
Preloads and Locales
Posted by Matt Marum <mg...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/545/#review390
-----------------------------------------------------------
Ship it!
LGTM
- Matt
On 2011-04-03 16:12:03, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/545/
> -----------------------------------------------------------
>
> (Updated 2011-04-03 16:12:03)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1521 and http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1088245
> /trunk/php/src/gadgets/GadgetFactory.php 1088245
> /trunk/php/src/gadgets/GadgetSpecParser.php 1088245
> /trunk/php/test/gadgets/GadgetFactoryTest.php 1088245
> /trunk/php/test/gadgets/GadgetTest.php 1088245
>
> Diff: https://reviews.apache.org/r/545/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>
Re: Review Request: PHP: View level support for Features,
Preloads and Locales
Posted by Paul Lindner <li...@inuus.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/545/#review389
-----------------------------------------------------------
Ship it!
lgtm...
- Paul
On 2011-04-03 16:12:03, Bastian Hofmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/545/
> -----------------------------------------------------------
>
> (Updated 2011-04-03 16:12:03)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> See https://issues.apache.org/jira/browse/SHINDIG-1521 and http://docs.opensocial.org/display/OSD/View+Level+Features+Proposal
>
>
> Diffs
> -----
>
> /trunk/php/src/gadgets/Gadget.php 1088245
> /trunk/php/src/gadgets/GadgetFactory.php 1088245
> /trunk/php/src/gadgets/GadgetSpecParser.php 1088245
> /trunk/php/test/gadgets/GadgetFactoryTest.php 1088245
> /trunk/php/test/gadgets/GadgetTest.php 1088245
>
> Diff: https://reviews.apache.org/r/545/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bastian
>
>