You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by gz...@apache.org on 2019/04/08 06:53:44 UTC
[camel] 04/04: Fix placeholders in logging statements
This is an automated email from the ASF dual-hosted git repository.
gzurowski pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 85ab63427be9f51f13f5042715fe7e8eba0aede8
Author: Gregor Zurowski <gr...@zurowski.org>
AuthorDate: Mon Apr 8 08:47:00 2019 +0200
Fix placeholders in logging statements
---
.../java/org/apache/camel/builder/XMLTokenExpressionIterator.java | 4 ++--
.../apache/camel/component/bean/AbstractCamelInvocationHandler.java | 2 +-
.../src/main/java/org/apache/camel/component/bean/BeanInfo.java | 2 +-
.../src/main/java/org/apache/camel/component/bean/MethodInfo.java | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/core/camel-core/src/main/java/org/apache/camel/builder/XMLTokenExpressionIterator.java b/core/camel-core/src/main/java/org/apache/camel/builder/XMLTokenExpressionIterator.java
index dd67a9a..ce44a39 100644
--- a/core/camel-core/src/main/java/org/apache/camel/builder/XMLTokenExpressionIterator.java
+++ b/core/camel-core/src/main/java/org/apache/camel/builder/XMLTokenExpressionIterator.java
@@ -221,7 +221,7 @@ public class XMLTokenExpressionIterator extends ExpressionAdapter implements Nam
// perform the first offset compliance test
int coff = reader.getLocation().getCharacterOffset();
if (coff != 0) {
- LOG.error("XMLStreamReader {} not supporting Location");
+ LOG.error("XMLStreamReader {} not supporting Location", reader);
throw new XMLStreamException("reader not supporting Location");
}
@@ -474,7 +474,7 @@ public class XMLTokenExpressionIterator extends ExpressionAdapter implements Nam
// perform the second compliance test
if (!compliant) {
if (token != null && token.startsWith("<") && !token.startsWith("<?")) {
- LOG.error("XMLStreamReader {} not supporting Location");
+ LOG.error("XMLStreamReader not supporting Location");
throw new XMLStreamException("reader not supporting Location");
}
compliant = true;
diff --git a/core/camel-core/src/main/java/org/apache/camel/component/bean/AbstractCamelInvocationHandler.java b/core/camel-core/src/main/java/org/apache/camel/component/bean/AbstractCamelInvocationHandler.java
index c667971..6f9b178 100644
--- a/core/camel-core/src/main/java/org/apache/camel/component/bean/AbstractCamelInvocationHandler.java
+++ b/core/camel-core/src/main/java/org/apache/camel/component/bean/AbstractCamelInvocationHandler.java
@@ -167,7 +167,7 @@ public abstract class AbstractCamelInvocationHandler implements InvocationHandle
if (binding) {
LOG.trace("Binding to service interface as @Body,@Header,@ExchangeProperty detected when calling proxy method: {}", method);
} else {
- LOG.trace("No binding to service interface as @Body,@Header,@ExchangeProperty not detected. Using BeanInvocation as message body when calling proxy method: {}");
+ LOG.trace("No binding to service interface as @Body,@Header,@ExchangeProperty not detected. Using BeanInvocation as message body when calling proxy method: {}", method);
}
return doInvoke(method, exchange);
diff --git a/core/camel-core/src/main/java/org/apache/camel/component/bean/BeanInfo.java b/core/camel-core/src/main/java/org/apache/camel/component/bean/BeanInfo.java
index b3a693c..25937a5 100644
--- a/core/camel-core/src/main/java/org/apache/camel/component/bean/BeanInfo.java
+++ b/core/camel-core/src/main/java/org/apache/camel/component/bean/BeanInfo.java
@@ -469,7 +469,7 @@ public class BeanInfo {
// will ignore the expression for parameter evaluation
}
}
- LOG.trace("Parameter #{} has parameter info: ", i, parameterInfo);
+ LOG.trace("Parameter #{} has parameter info: {}", i, parameterInfo);
}
// now let's add the method to the repository
diff --git a/core/camel-core/src/main/java/org/apache/camel/component/bean/MethodInfo.java b/core/camel-core/src/main/java/org/apache/camel/component/bean/MethodInfo.java
index 2fba6ad..b05371a 100644
--- a/core/camel-core/src/main/java/org/apache/camel/component/bean/MethodInfo.java
+++ b/core/camel-core/src/main/java/org/apache/camel/component/bean/MethodInfo.java
@@ -780,7 +780,7 @@ public class MethodInfo {
// its a valid parameter value, so convert it to the expected type of the parameter
answer = exchange.getContext().getTypeConverter().mandatoryConvertTo(parameterType, exchange, parameterValue);
if (LOG.isTraceEnabled()) {
- LOG.trace("Parameter #{} evaluated as: {} type: ", index, answer, org.apache.camel.util.ObjectHelper.type(answer));
+ LOG.trace("Parameter #{} evaluated as: {} type: {}", index, answer, org.apache.camel.util.ObjectHelper.type(answer));
}
} catch (Exception e) {
if (LOG.isDebugEnabled()) {
@@ -813,7 +813,7 @@ public class MethodInfo {
answer = exchange.getContext().getTypeConverter().mandatoryConvertTo(parameterType, result);
}
if (LOG.isTraceEnabled()) {
- LOG.trace("Parameter #{} evaluated as: {} type: ", index, answer, org.apache.camel.util.ObjectHelper.type(answer));
+ LOG.trace("Parameter #{} evaluated as: {} type: {}", index, answer, org.apache.camel.util.ObjectHelper.type(answer));
}
} catch (NoTypeConversionAvailableException e) {
if (LOG.isDebugEnabled()) {