[GitHub] [iceberg] JonasJ-ap commented on pull request #5644: AWS: Add s3.dualstack-enabled flag to AwsProperties

[GitBox <gi...@apache.org>]

JonasJ-ap commented on PR #5644:
URL: https://github.com/apache/iceberg/pull/5644#issuecomment-1230728023

   > Thanks for the investigation! In that case let's keep the flag `s3.dualstack-enabled` for now. This looks good to me. @JonasJ-ap can you also update the documentation in `aws.md`?
   > 
   > We do miss the code logic in other client factories, but it seems like we should do some refactoring such that all the configs are applied to all client factories, it can be a separated PR.
   > 
   > cc @amogh-jahagirdar , @singhpk234 let me know if you have any comments.
   
   I plan to do the refactoring to make all configs apply to all client factories in my next PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org