You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twopensource.com> on 2014/09/11 20:20:16 UTC
Review Request 25548: Apply GzipFilter to POSTs as well as GETs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25548/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Bill Farner.
Bugs: AURORA-697
https://issues.apache.org/jira/browse/AURORA-697
Repository: aurora
Description
-------
Apply GzipFilter to POSTs as well as GETs
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362
src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 2c31df6d0ac1c58e02b13d61ba9f511b781a20a7
Diff: https://reviews.apache.org/r/25548/diff/
Testing
-------
./gradlew build -Pq
Also verified content-encoding against response from scheduler in vagrant image:
$ curl -s -D - -o /dev/null -H "Accept-Encoding: gzip" -X POST -d @- \
> http://192.168.33.7:8081/api <<EOF |tr '\r' '\n' |grep "Content-Encoding" |awk '{print $2}' \
> |tr '[:upper:]' '[:lower]'
> [1,"getJobSummary",1,0,{"1":{"str":"vagrant"}}]
> EOF
gzip
Thanks,
Joshua Cohen
Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25548/#review53105
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 11, 2014, 6:20 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25548/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 6:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-697
> https://issues.apache.org/jira/browse/AURORA-697
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Apply GzipFilter to POSTs as well as GETs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 2c31df6d0ac1c58e02b13d61ba9f511b781a20a7
>
> Diff: https://reviews.apache.org/r/25548/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Also verified content-encoding against response from scheduler in vagrant image:
>
> $ curl -s -D - -o /dev/null -H "Accept-Encoding: gzip" -X POST -d @- \
> > http://192.168.33.7:8081/api <<EOF |tr '\r' '\n' |grep "Content-Encoding" |awk '{print $2}' \
> > |tr '[:upper:]' '[:lower]'
> > [1,"getJobSummary",1,0,{"1":{"str":"vagrant"}}]
> > EOF
> gzip
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25548/#review53109
-----------------------------------------------------------
Pushed to Apache master.
- David McLaughlin
On Sept. 11, 2014, 6:20 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25548/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 6:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-697
> https://issues.apache.org/jira/browse/AURORA-697
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Apply GzipFilter to POSTs as well as GETs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 2c31df6d0ac1c58e02b13d61ba9f511b781a20a7
>
> Diff: https://reviews.apache.org/r/25548/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Also verified content-encoding against response from scheduler in vagrant image:
>
> $ curl -s -D - -o /dev/null -H "Accept-Encoding: gzip" -X POST -d @- \
> > http://192.168.33.7:8081/api <<EOF |tr '\r' '\n' |grep "Content-Encoding" |awk '{print $2}' \
> > |tr '[:upper:]' '[:lower]'
> > [1,"getJobSummary",1,0,{"1":{"str":"vagrant"}}]
> > EOF
> gzip
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25548/#review53084
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Sept. 11, 2014, 6:20 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25548/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 6:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Bill Farner.
>
>
> Bugs: AURORA-697
> https://issues.apache.org/jira/browse/AURORA-697
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Apply GzipFilter to POSTs as well as GETs
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362
> src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 2c31df6d0ac1c58e02b13d61ba9f511b781a20a7
>
> Diff: https://reviews.apache.org/r/25548/diff/
>
>
> Testing
> -------
>
> ./gradlew build -Pq
>
> Also verified content-encoding against response from scheduler in vagrant image:
>
> $ curl -s -D - -o /dev/null -H "Accept-Encoding: gzip" -X POST -d @- \
> > http://192.168.33.7:8081/api <<EOF |tr '\r' '\n' |grep "Content-Encoding" |awk '{print $2}' \
> > |tr '[:upper:]' '[:lower]'
> > [1,"getJobSummary",1,0,{"1":{"str":"vagrant"}}]
> > EOF
> gzip
>
>
> Thanks,
>
> Joshua Cohen
>
>