You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2020/04/22 06:16:42 UTC
[kudu-CR] [c++17] Corrected call of boost::make optional()
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15781
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
[c++17] Corrected call of boost::make_optional()
Without specifying "boost" namespace C++17 compiler treats
make_optional() as std::make_optional() and produces error:
./../src/kudu/master/placement_policy-test.cc:1014:49: error:
no viable conversion
from 'optional<decay_t<std::__cxx11::basic_string<char> > >'
(aka 'optional<std::__cxx11::basic_string<char> >')
to 'const boost::optional<std::string>'
(aka 'const optional<basic_string<char> >')
ASSERT_OK(policy.PlaceTabletReplicas(3,
make_optional(string(label)), &result));
Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
---
M src/kudu/master/placement_policy-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/15781/1
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc
File src/kudu/master/placement_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@44
PS1, Line 44: using boost::optional;
+1 to Alexey's comment.
Better to remove this line as well.
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 22 Apr 2020 19:30:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc
File src/kudu/master/placement_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@1014
PS1, Line 1014: boost::
There is 'using boost::make_optional' directive in the beginning of this file. Isn't it effective here? I suspect template parameter specification might help the compiler to make proper resolution. Otherwise, consider removing 'using boost::make_optional' from the beginning of the file.
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 22 Apr 2020 15:43:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Grant Henke, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15781
to look at the new patch set (#2).
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
[c++17] Corrected call of boost::make_optional()
Without specifying "boost" namespace C++17 compiler treats
make_optional() as std::make_optional() and produces error:
./../src/kudu/master/placement_policy-test.cc:1014:49: error:
no viable conversion
from 'optional<decay_t<std::__cxx11::basic_string<char> > >'
(aka 'optional<std::__cxx11::basic_string<char> >')
to 'const boost::optional<std::string>'
(aka 'const optional<basic_string<char> >')
ASSERT_OK(policy.PlaceTabletReplicas(3,
make_optional(string(label)), &result));
Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
---
M src/kudu/master/placement_policy-test.cc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/15781/2
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2020 23:07:36 +0000
Gerrit-HasComments: No
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
[c++17] Corrected call of boost::make_optional()
Without specifying "boost" namespace C++17 compiler treats
make_optional() as std::make_optional() and produces error:
./../src/kudu/master/placement_policy-test.cc:1014:49: error:
no viable conversion
from 'optional<decay_t<std::__cxx11::basic_string<char> > >'
(aka 'optional<std::__cxx11::basic_string<char> >')
to 'const boost::optional<std::string>'
(aka 'const optional<basic_string<char> >')
ASSERT_OK(policy.PlaceTabletReplicas(3,
make_optional(string(label)), &result));
Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Reviewed-on: http://gerrit.cloudera.org:8080/15781
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/placement_policy-test.cc
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2020 22:44:25 +0000
Gerrit-HasComments: No
[kudu-CR] [c++17] Corrected call of boost::make optional()
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15781 )
Change subject: [c++17] Corrected call of boost::make_optional()
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc
File src/kudu/master/placement_policy-test.cc:
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@44
PS1, Line 44: using std::initializer_list;
> +1 to Alexey's comment.
Done
http://gerrit.cloudera.org:8080/#/c/15781/1/src/kudu/master/placement_policy-test.cc@1014
PS1, Line 1014:
> There is 'using boost::make_optional' directive in the beginning of this fi
Done
--
To view, visit http://gerrit.cloudera.org:8080/15781
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I553ce8275508914cfa322a05fe2adfcd802372ad
Gerrit-Change-Number: 15781
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Apr 2020 21:41:01 +0000
Gerrit-HasComments: Yes