You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/02/01 07:12:25 UTC

[kudu-CR] [KUDU-3438] TabletCopyClientAbortTest maybe core

Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19451 )

Change subject: [KUDU-3438] TabletCopyClientAbortTest maybe core
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/19451/3//COMMIT_MSG@14
PS3, Line 14: It is better to Add NO_FATALS() for TabletCopyClientTest::SetUp()
            : to avoid nullptr TabletCopyClient.
I see there is already a NO_FATALS in https://github.com/apache/kudu/blob/57aa482673d97506c22273e5e0f37c4b43c7fb64/src/kudu/tserver/tablet_copy_client-test.cc#L112. It seems that the crash occurs in TabletCopyTest::SetUp() according to the core dump stack in the JIRA.



-- 
To view, visit http://gerrit.cloudera.org:8080/19451
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1eeea183bf9fc0b566e6a70f2f7520f34b2ae3c
Gerrit-Change-Number: 19451
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 01 Feb 2023 07:12:25 +0000
Gerrit-HasComments: Yes