You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "suryaprasanna (via GitHub)" <gi...@apache.org> on 2023/04/27 21:46:02 UTC
[GitHub] [hudi] suryaprasanna opened a new pull request, #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
suryaprasanna opened a new pull request, #8590:
URL: https://github.com/apache/hudi/pull/8590
### Change Logs
All write support classes should extend HoodieAvoWriteSupport, the change uses Reflection APIs, to load sub classes of HoodieAvroWriteSupport. This approach is useful to override writeContext and other methods.
### Impact
By default HoodieAvoWriteSupport is still used, so there is not impact.
### Risk level (write none, low medium or high below)
None
### Documentation Update
A new config hoodie.avro.write.support.class is added under HoodieStorageConfig class, which is used to load sub classes of HoodieAvoWriteSupport ar runtime.
### Contributor's checklist
- [*] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [*] Change Logs and Impact were stated clearly
- [] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1224883918
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -170,6 +170,14 @@ public class HoodieStorageConfig extends HoodieConfig {
.withDocumentation("Expected additional compression as records move from log files to parquet. Used for merge_on_read "
+ "table to send inserts into log files & control the size of compacted parquet file.");
+ public static final ConfigProperty<String> HOODIE_AVRO_WRITE_SUPPORT_CLASS = ConfigProperty
+ .key("hoodie.avro.write.support.class")
+ .defaultValue("org.apache.hudi.avro.HoodieAvroWriteSupport")
+ .markAdvanced()
Review Comment:
nit: add `.sinceVersion("0.14.0")`
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/SparkHelpers.scala:
##########
@@ -42,8 +43,9 @@ object SparkHelpers {
val schema: Schema = sourceRecords.get(0).getSchema
val filter: BloomFilter = BloomFilterFactory.createBloomFilter(HoodieIndexConfig.BLOOM_FILTER_NUM_ENTRIES_VALUE.defaultValue.toInt, HoodieIndexConfig.BLOOM_FILTER_FPP_VALUE.defaultValue.toDouble,
HoodieIndexConfig.BLOOM_INDEX_FILTER_DYNAMIC_MAX_ENTRIES.defaultValue.toInt, HoodieIndexConfig.BLOOM_FILTER_TYPE.defaultValue);
- val writeSupport: HoodieAvroWriteSupport = new HoodieAvroWriteSupport(new AvroSchemaConverter(fs.getConf).convert(schema), schema, org.apache.hudi.common.util.Option.of(filter))
- val parquetConfig: HoodieParquetConfig[HoodieAvroWriteSupport] =
+ val writeSupport: HoodieAvroWriteSupport[_] = new HoodieAvroWriteSupport(new AvroSchemaConverter(fs.getConf).convert(schema),
Review Comment:
I see this is only used by `DedupeSparkJob`. Could you follow up in a separate PR to see if this needs to use the configured class from `hoodie.avro.write.support.class` too?
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileWriterFactory.java:
##########
@@ -106,4 +106,14 @@ protected HoodieFileWriter newOrcFileWriter(
config.getLong(HoodieStorageConfig.ORC_FILE_MAX_SIZE), filter);
return new HoodieAvroOrcWriter(instantTime, path, orcConfig, schema, taskContextSupplier);
}
+
+ private HoodieAvroWriteSupport getHoodieAvroWriteSupport(Configuration conf, Schema schema,
+ HoodieConfig config, boolean enableBloomFilter) {
+ Option<BloomFilter> filter = enableBloomFilter ? Option.of(createBloomFilter(config)) : Option.empty();
+ HoodieAvroWriteSupport writeSupport = (HoodieAvroWriteSupport) ReflectionUtils.loadClass(
Review Comment:
I'm thinking we can keep `HoodieBaseAvroWriteSupport` abstract and still provide the actual implementation in `HoodieAvroWriteSupport`. This is more cosmetic. I'm still ok with the current approach.
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroWriteSupport.java:
##########
@@ -35,17 +36,19 @@
/**
* Wrap AvroWriterSupport for plugging in the bloom filter.
*/
-public class HoodieAvroWriteSupport extends AvroWriteSupport {
+public class HoodieAvroWriteSupport<T> extends AvroWriteSupport<T> {
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1186316626
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -170,6 +170,12 @@ public class HoodieStorageConfig extends HoodieConfig {
.withDocumentation("Expected additional compression as records move from log files to parquet. Used for merge_on_read "
+ "table to send inserts into log files & control the size of compacted parquet file.");
+ public static final ConfigProperty<String> HOODIE_AVRO_WRITE_SUPPORT_CLASS = ConfigProperty
+ .key("hoodie.avro.write.support.class")
+ .defaultValue("org.apache.hudi.avro.HoodieAvroWriteSupport")
Review Comment:
Since this is advanced, could you mark this with `.markAdvanced()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1179858534
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -698,6 +698,7 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+
Review Comment:
nit: no need to add new line
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroWriteSupport.java:
##########
@@ -35,17 +36,19 @@
/**
* Wrap AvroWriterSupport for plugging in the bloom filter.
*/
-public class HoodieAvroWriteSupport extends AvroWriteSupport {
+public class HoodieAvroWriteSupport<T> extends AvroWriteSupport<T> {
Review Comment:
Seems like this type parameter `<T>` is not needed?
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileWriterFactory.java:
##########
@@ -106,4 +106,14 @@ protected HoodieFileWriter newOrcFileWriter(
config.getLong(HoodieStorageConfig.ORC_FILE_MAX_SIZE), filter);
return new HoodieAvroOrcWriter(instantTime, path, orcConfig, schema, taskContextSupplier);
}
+
+ private HoodieAvroWriteSupport getHoodieAvroWriteSupport(Configuration conf, Schema schema,
+ HoodieConfig config, boolean enableBloomFilter) {
+ Option<BloomFilter> filter = enableBloomFilter ? Option.of(createBloomFilter(config)) : Option.empty();
+ HoodieAvroWriteSupport writeSupport = (HoodieAvroWriteSupport) ReflectionUtils.loadClass(
Review Comment:
Wondering if we should introduce a new abstract class `HoodieBaseAvroWriteSupport` (`HoodieAvroWriteSupport` will extend `HoodieBaseAvroWriteSupport`) and use that here, instead of directly using `HoodieAvroWriteSupport`. So other custom implementation may extend `HoodieBaseAvroWriteSupport` or reuse part of `HoodieAvroWriteSupport` if needed. Right now it has to extend `HoodieAvroWriteSupport`. @suryaprasanna @vinothchandar wdyt?
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -170,6 +170,12 @@ public class HoodieStorageConfig extends HoodieConfig {
.withDocumentation("Expected additional compression as records move from log files to parquet. Used for merge_on_read "
+ "table to send inserts into log files & control the size of compacted parquet file.");
+ public static final ConfigProperty<String> HOODIE_AVRO_WRITE_SUPPORT_CLASS = ConfigProperty
+ .key("hoodie.avro.write.support.class")
+ .defaultValue("org.apache.hudi.avro.HoodieAvroWriteSupport")
+ .withDocumentation("Different write support classes can be loaded at runtime. This is only required when trying to "
Review Comment:
Based on the logic, the class has to be a subclass of `HoodieAvroWriteSupport`. Could you add the docs mentioning that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] suryaprasanna commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "suryaprasanna (via GitHub)" <gi...@apache.org>.
suryaprasanna commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1207475998
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieAvroFileWriterFactory.java:
##########
@@ -106,4 +106,14 @@ protected HoodieFileWriter newOrcFileWriter(
config.getLong(HoodieStorageConfig.ORC_FILE_MAX_SIZE), filter);
return new HoodieAvroOrcWriter(instantTime, path, orcConfig, schema, taskContextSupplier);
}
+
+ private HoodieAvroWriteSupport getHoodieAvroWriteSupport(Configuration conf, Schema schema,
+ HoodieConfig config, boolean enableBloomFilter) {
+ Option<BloomFilter> filter = enableBloomFilter ? Option.of(createBloomFilter(config)) : Option.empty();
+ HoodieAvroWriteSupport writeSupport = (HoodieAvroWriteSupport) ReflectionUtils.loadClass(
Review Comment:
AvroWriteSupport which is from the parquet-avro library already has a base implementation. We are over-ridding that class with HoodieAvroWriteSupport to include bloom filter and some footer metadata.
So, will it be confusing to users, if we call this class a base class and do not provide any other implementation for this class on the repository?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1565109530
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
}, {
"hash" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425",
"triggerID" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"triggerType" : "PUSH"
}, {
"hash" : "744c9526f7a8ac76af368643b612c04dd4462205",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17427",
"triggerID" : "744c9526f7a8ac76af368643b612c04dd4462205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed52ccec20bc239fafb3b1a540411a252b57161f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425)
* 744c9526f7a8ac76af368643b612c04dd4462205 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17427)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1565183287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
}, {
"hash" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425",
"triggerID" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"triggerType" : "PUSH"
}, {
"hash" : "744c9526f7a8ac76af368643b612c04dd4462205",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17427",
"triggerID" : "744c9526f7a8ac76af368643b612c04dd4462205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 744c9526f7a8ac76af368643b612c04dd4462205 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17427)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] suryaprasanna commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "suryaprasanna (via GitHub)" <gi...@apache.org>.
suryaprasanna commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1207466099
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -170,6 +170,12 @@ public class HoodieStorageConfig extends HoodieConfig {
.withDocumentation("Expected additional compression as records move from log files to parquet. Used for merge_on_read "
+ "table to send inserts into log files & control the size of compacted parquet file.");
+ public static final ConfigProperty<String> HOODIE_AVRO_WRITE_SUPPORT_CLASS = ConfigProperty
+ .key("hoodie.avro.write.support.class")
+ .defaultValue("org.apache.hudi.avro.HoodieAvroWriteSupport")
Review Comment:
Yes, added markAdvanced to the config.
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroWriteSupport.java:
##########
@@ -35,17 +36,19 @@
/**
* Wrap AvroWriterSupport for plugging in the bloom filter.
*/
-public class HoodieAvroWriteSupport extends AvroWriteSupport {
+public class HoodieAvroWriteSupport<T> extends AvroWriteSupport<T> {
Review Comment:
I think, if users are over-ridding write() method from the AvroWriteSupport class, they require the generics to be passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1526645612
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1526659953
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1565104682
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
}, {
"hash" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425",
"triggerID" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"triggerType" : "PUSH"
}, {
"hash" : "744c9526f7a8ac76af368643b612c04dd4462205",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "744c9526f7a8ac76af368643b612c04dd4462205",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713)
* ed52ccec20bc239fafb3b1a540411a252b57161f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425)
* 744c9526f7a8ac76af368643b612c04dd4462205 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] suryaprasanna commented on a diff in pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "suryaprasanna (via GitHub)" <gi...@apache.org>.
suryaprasanna commented on code in PR #8590:
URL: https://github.com/apache/hudi/pull/8590#discussion_r1207490271
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -698,6 +698,7 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "will not print any configuration which contains the configured filter. For example with "
+ "a configured filter `ssl`, value for config `ssl.trustore.location` would be masked.");
+
Review Comment:
Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8590:
URL: https://github.com/apache/hudi/pull/8590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1526854211
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1565069098
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
}, {
"hash" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713)
* ed52ccec20bc239fafb3b1a540411a252b57161f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8590: [HUDI-3545] [UBER] Make HoodieAvroWriteSupport class configurable
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8590:
URL: https://github.com/apache/hudi/pull/8590#issuecomment-1565071989
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713",
"triggerID" : "c9ffac46b68ebb82eb65cb867d579345a2abeac9",
"triggerType" : "PUSH"
}, {
"hash" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425",
"triggerID" : "ed52ccec20bc239fafb3b1a540411a252b57161f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c9ffac46b68ebb82eb65cb867d579345a2abeac9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=16713)
* ed52ccec20bc239fafb3b1a540411a252b57161f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17425)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org