You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "walterddr (via GitHub)" <gi...@apache.org> on 2023/04/22 19:44:20 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #10671: [draft] clean up stagemetadata

walterddr commented on code in PR #10671:
URL: https://github.com/apache/pinot/pull/10671#discussion_r1174455253


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/StageMetadata.java:
##########
@@ -75,43 +73,21 @@ public void addScannedTable(String tableName) {
   // attached physical plan context.
   // -----------------------------------------------
 
-  public Map<ServerInstance, Map<String, List<String>>> getServerInstanceToSegmentsMap() {
-    return _serverInstanceToSegmentsMap;
-  }
-
-  public void setServerInstanceToSegmentsMap(

Review Comment:
   all setters should be moved to `DispatchablePlanContext` which gradually completes the stage metadata. 
   
   removing all setter makes StageMetadata immutable



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org