[jira] [Commented] (LUCENE-3495) BlockJoinQuery doesn't implement boost

["Michael McCandless (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122128#comment-13122128 ] 

Michael McCandless commented on LUCENE-3495:
--------------------------------------------

+1 looks good!

                
> BlockJoinQuery doesn't implement boost
> --------------------------------------
>
>                 Key: LUCENE-3495
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3495
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.4
>            Reporter: Robert Muir
>             Fix For: 3.5, 4.0
>
>         Attachments: LUCENE-3495.patch
>
>
> After reviewing LUCENE-3494, i checked other queries and noticed that BlockJoinQuery currently throws UOE for getBoost and setBoost:
> {noformat}
> throw new UnsupportedOperationException("this query cannot support boosting; please use childQuery.setBoost instead");
> {noformat}
> I don't think we can safely do that in queries, because other parts of lucene rely upon this working... for example BQs rewrite when
> it has a single clause and erases itself.
> So I think we should just pass down the boost to the inner weight.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org