You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/06/03 22:26:47 UTC

[GitHub] [drill] laurentgo opened a new pull request #2247: DRILL-7945: Stop patching newly added Guava methods

laurentgo opened a new pull request #2247:
URL: https://github.com/apache/drill/pull/2247


   # [DRILL-7945](https://issues.apache.org/jira/browse/DRILL-7945): Stop patching newly added Guava methods
   
   ## Description
   
   In order to support Apache Iceberg, GuavaPatcher adds several methods to
   com.google.common.base.Preconditions required by Apache Iceberg runtime
   but not available in Guava 18.
   
   When Guava version was updated to 30.1.1, Guava Patcher tries to update
   existing methods with some code referencing package protected methods
   which do no exist anymore. Patching fails but as the methods do now
   exists, there's no compatibility issue. That said, GuavaPatcher emits
   some logging which might confuse end user.
   
   Remove the unnecessary patching of the Preconditions class and also add
   some unit test designed to fail if patching fails for any reason.
   
   
   ## Documentation
   N/A
   
   ## Testing
   Unit tests
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2247: DRILL-7945: Stop patching newly added Guava methods

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2247:
URL: https://github.com/apache/drill/pull/2247#issuecomment-854286788


   @vvysotskyi Thanks for the report. Can we also approve this PR for the emergency fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] luocooong commented on pull request #2247: DRILL-7945: Stop patching newly added Guava methods

Posted by GitBox <gi...@apache.org>.
luocooong commented on pull request #2247:
URL: https://github.com/apache/drill/pull/2247#issuecomment-854286788


   @vvysotskyi Thanks for the report. Can we also approve this PR for the emergency fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] laurentgo merged pull request #2247: DRILL-7945: Stop patching newly added Guava methods

Posted by GitBox <gi...@apache.org>.
laurentgo merged pull request #2247:
URL: https://github.com/apache/drill/pull/2247


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org