You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gu...@apache.org on 2017/11/19 18:54:54 UTC
kafka git commit: KAFKA-6233: Removed unnecessary null check in
StringSerializer
Repository: kafka
Updated Branches:
refs/heads/trunk 40fd9fa98 -> 83b8cf96f
KAFKA-6233: Removed unnecessary null check in StringSerializer
Removed unnecessary null check
if (encodingValue != null && encodingValue instanceof String)
null instanceof String returns false hence replaced the check with
if (encodingValue instanceof String)
Author: Sagar Chavan <sa...@gmail.com>
Reviewers: Guozhang Wang <wa...@gmail.com>
Closes #4232 from sagarchavan3172/trunk
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/83b8cf96
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/83b8cf96
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/83b8cf96
Branch: refs/heads/trunk
Commit: 83b8cf96f92242d61db9e87aafce1e8dc457c1a1
Parents: 40fd9fa
Author: Sagar Chavan <sa...@gmail.com>
Authored: Sun Nov 19 10:54:50 2017 -0800
Committer: Guozhang Wang <wa...@gmail.com>
Committed: Sun Nov 19 10:54:50 2017 -0800
----------------------------------------------------------------------
.../org/apache/kafka/common/serialization/StringSerializer.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/83b8cf96/clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
----------------------------------------------------------------------
diff --git a/clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java b/clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
index c2862dd..28e4174 100644
--- a/clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
+++ b/clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
@@ -34,7 +34,7 @@ public class StringSerializer implements Serializer<String> {
Object encodingValue = configs.get(propertyName);
if (encodingValue == null)
encodingValue = configs.get("serializer.encoding");
- if (encodingValue != null && encodingValue instanceof String)
+ if (encodingValue instanceof String)
encoding = (String) encodingValue;
}