Re: [PR] [Improvement-17908][Flink] Make -sae parameter configurable in UI with default off [dolphinscheduler]

["chris-fast (via GitHub)" <gi...@apache.org>]

chris-fast commented on code in PR #17909:
URL: https://github.com/apache/dolphinscheduler/pull/17909#discussion_r2753780981


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/main/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkParameters.java:
##########
@@ -114,6 +114,21 @@ public class FlinkParameters extends AbstractParameters {
      */
     private String rawScript;
 
+    /**
+     * Shutdown on attached exit (-sae parameter)
+     *
+     * <p>When enabled, Flink CLI will attempt to shutdown the cluster when the CLI
+     * terminates abruptly. This is only suitable for attached mode (CLUSTER/LOCAL).
+     *
+     * <p>For APPLICATION mode, this should typically be disabled as the job runs
+     * in detached mode on YARN.
+     *
+     * <p>Default: false (disabled for safety)
+     *
+     * @see FlinkArgsUtils#buildRunCommandLine
+     */
+    private Boolean shutdownOnAttachedExit;

Review Comment:
   I'm with you on that. We can't let the system become too unwieldy to manage，and using -sea is not a bad thing in this scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org