You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/16 06:56:59 UTC
[GitHub] [flink] DashShen opened a new pull request #12911: [hotfix][k8s] fix checkstyle problem
DashShen opened a new pull request #12911:
URL: https://github.com/apache/flink/pull/12911
File should be end with a new line. This PR append the missing line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659212989
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4550",
"triggerID" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91f2d2538a46e3775018153d0e48569793aa82a3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4550)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen closed pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
DashShen closed pull request #12911:
URL: https://github.com/apache/flink/pull/12911
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
DashShen commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659776124
@zentol There is trully a rule constrains that file should be end with a new line.
```xml
<module name="Checker">
....
<module name="NewlineAtEndOfFile">
<!-- windows can use \r\n vs \n, so enforce the most used one ie UNIx style -->
<property name="lineSeparator" value="lf" />
</module>
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659212989
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91f2d2538a46e3775018153d0e48569793aa82a3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659934453
Doesn't seem to be working though, since all builds should then be failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659212989
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4550",
"triggerID" : "91f2d2538a46e3775018153d0e48569793aa82a3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91f2d2538a46e3775018153d0e48569793aa82a3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4550)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen edited a comment on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
DashShen edited a comment on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659776124
@zentol There is trully a rule constrains file should be end with a new line.
```xml
<module name="Checker">
....
<module name="NewlineAtEndOfFile">
<!-- windows can use \r\n vs \n, so enforce the most used one ie UNIx style -->
<property name="lineSeparator" value="lf" />
</module>
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
DashShen commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659994442
@zentol Well, it seems not work on building, but I think it's necessary to obey the rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] DashShen edited a comment on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
DashShen edited a comment on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659776124
@zentol There is trully a rule constrains file that should be end with a new line.
```xml
<module name="Checker">
....
<module name="NewlineAtEndOfFile">
<!-- windows can use \r\n vs \n, so enforce the most used one ie UNIx style -->
<property name="lineSeparator" value="lf" />
</module>
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659200156
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 91f2d2538a46e3775018153d0e48569793aa82a3 (Thu Jul 16 06:59:00 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on pull request #12911: [hotfix][k8s] fix checkstyle problem
Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12911:
URL: https://github.com/apache/flink/pull/12911#issuecomment-659286064
There is no rule that files should end with a new-line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org