[GitHub] [incubator-weex] lucky-chen commented on a change in pull request #2854: Feature/try fix top native crash fd problem

[GitBox <gi...@apache.org>]

lucky-chen commented on a change in pull request #2854: Feature/try fix top native crash fd problem
URL: https://github.com/apache/incubator-weex/pull/2854#discussion_r318379709
 
 

 ##########
 File path: weex_core/Source/android/multiprocess/weex_js_connection.cpp
 ##########
 @@ -617,3 +602,43 @@ int copyFile(const char *SourceFile, const char *NewFile) {
     return 1;
   }
 }
+
+void *WeexConnInfo::mmap_for_ipc() {
+  pid_t pid = getpid();
+  std::string clientName(this->is_client ? "WEEX_IPC_CLIENT" : "WEEX_IPC_SERVER");
 
 Review comment:
   "clientName" is confusing, Actually it means “client/server” mmap name。 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services