You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "goldjee (via GitHub)" <gi...@apache.org> on 2024/05/07 15:01:12 UTC
[PR] fix(i18n): improved Russian translation [superset]
goldjee opened a new pull request, #28371:
URL: https://github.com/apache/superset/pull/28371
### SUMMARY
This is a pretty big change to Russian translation.
- Extracted new strings and updated language files, as described in the [documentation](https://superset.apache.org/docs/contributing/howtos#extracting-new-strings-for-translation).
- Normalized usage of dots at the end of sentences. The rule is simple: if given label contains only one sentence, it should not be ended with a dot. On the contrary, labels comprised of several sentences should be ended with a dot.
- Normalized usage of "е" and "ё" symbols. As there was no "ё" pretty much everywhere and people are used to omit dots above this symbol, I have changed "ё" to "е" everywhere this symbol occurs.
- Fixed typos and written language style issues.
- Renamed chart to "Диаграмма" (previously it was called "График"). The reason is that "график" is a word that means "line plot". As most of visuals types are not plots, it is much more correct to call them "диаграмма" (diagram, chart) instead.
- Normalized naming of various chart types.
- Used English names for things where it is appropriate. For instance, "Superset" should not be translated to "Суперсет", as it is a proper noun.
- Added quite a bunch of missing strings, corrected and confirmed some drafts.
- Shortened some strings for the sake of brevity and to make them fit into tight spaces.
Of course, there is still a lot of work to do, but I have managed to cover the most frequently viewed UI elements and pages. Hope the team and end users will find this version alright.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): improved Russian translation [superset]
Posted by "goldjee (via GitHub)" <gi...@apache.org>.
goldjee commented on PR #28371:
URL: https://github.com/apache/superset/pull/28371#issuecomment-2110818238
Thank you for your feedback!
I'm not sure how the license header in .pot file got altered as I haven't touched the file manually. In order to fix that, I have ran
```
pre-commit run --all-files
./scripts/babel_update.sh
./scripts/po2json.sh
```
Seems that the ASF license header is back and the branch now passes pre-commit checks. I hope it's good now.
Regarding .po rearrangement, yeah, I can see it happens after running babel_update.sh and affects all the language files. The content was shuffled despite I haven't pulled any updates from the upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): improved Russian translation [superset]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #28371:
URL: https://github.com/apache/superset/pull/28371#issuecomment-2098647912
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/28371?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 64.08%. Comparing base [(`2e5f3ed`)](https://app.codecov.io/gh/apache/superset/commit/2e5f3ed85149951200645e00e79a543de9bec02f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`12215d8`)](https://app.codecov.io/gh/apache/superset/pull/28371?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 43 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #28371 +/- ##
==========================================
+ Coverage 60.49% 64.08% +3.59%
==========================================
Files 1931 521 -1410
Lines 76241 37184 -39057
Branches 8566 0 -8566
==========================================
- Hits 46122 23830 -22292
+ Misses 28015 13354 -14661
+ Partials 2104 0 -2104
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.10% <ø> (-0.06%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.70% <ø> (-0.10%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.08% <ø> (+0.59%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/28371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.29% <ø> (+0.66%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/28371?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): improved Russian translation [superset]
Posted by "goldjee (via GitHub)" <gi...@apache.org>.
goldjee closed pull request #28371: fix(i18n): improved Russian translation
URL: https://github.com/apache/superset/pull/28371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): improved Russian translation [superset]
Posted by "goldjee (via GitHub)" <gi...@apache.org>.
goldjee commented on PR #28371:
URL: https://github.com/apache/superset/pull/28371#issuecomment-2109440120
@villebro @rusackas @john-bodley do you have any plans on merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(i18n): improved Russian translation [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #28371:
URL: https://github.com/apache/superset/pull/28371#issuecomment-2110614939
I would love to! We need to contend with a few things, however:
* It seems like the ASF license was removed from the `.pot` file (maybe it was replaced instead of being edited? I'm not sure what did this)
* It looks like there are some linting issues that can probably be resolved by the pre-commit hook: https://superset.apache.org/docs/contributing/development/#git-hooks
* This isn't your fault, but I don't know what to do yet... clearly you only touched one language, but ALL the language files are re-ordered somewhat randomly. We have a few translation PRs doing this, which means we're probably going to have conflict nightmares until we find a way to get these .pot/.po/.json files to be rendered more deterministically. Not sure if @villebro happens to know anything about this... it's on my investigation list, and I swear I saw a PR claiming to fix this get merged not so long ago.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org