You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/10 06:03:08 UTC

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #840: ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server

jhuan31 commented on a change in pull request #840:  ZOOKEEPER-3143 Pluggable metrics system for ZooKeeper - Data Collection on Server
URL: https://github.com/apache/zookeeper/pull/840#discussion_r264024534
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatchManagerOptimized.java
 ##########
 @@ -68,6 +68,8 @@
     private final WatcherCleaner watcherCleaner;
 
     private final ReentrantReadWriteLock addRemovePathRWLock = new ReentrantReadWriteLock();
+    
+    private ServerMetrics serverMetrics = ServerMetrics.NULL_METRICS;
 
 Review comment:
   I can't figure out when the serverMetrics is set for the WatchManager and WatchManagerOptimized. The setter is called in tests only (Or do I miss something?). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services