You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/12/04 17:57:58 UTC

[GitHub] nswamy commented on a change in pull request #13493: [MXNET-1224]: improve scala maven jni build.

nswamy commented on a change in pull request #13493: [MXNET-1224]: improve scala maven jni build.
URL: https://github.com/apache/incubator-mxnet/pull/13493#discussion_r238772896
 
 

 ##########
 File path: scala-package/init-native/linux-x86_64/pom.xml
 ##########
 @@ -62,22 +66,24 @@
             <compilerStartOption>-std=c++0x</compilerStartOption>
           </compilerStartOptions>
           <compilerEndOptions>
-            <compilerEndOption>-I${project.basedir}/../../../include</compilerEndOption>
-            <compilerEndOption>${all_includes}</compilerEndOption>
-            <compilerEndOption>${cflags}</compilerEndOption>
+            <compilerEndOption>-I${MXNET_DIR}/include</compilerEndOption>
 
 Review comment:
   Can we use the C_FLAGS and LD_FLAGS defined and passed from the Makefile

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services