You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/02 12:04:24 UTC
[GitHub] [rocketmq] zyx333 opened a new issue, #4766: No error message is logged in catch block
zyx333 opened a new issue, #4766:
URL: https://github.com/apache/rocketmq/issues/4766
It's better to print error message here for the convenience of debugging.
https://github.com/apache/rocketmq/blob/0d1eec2b9ca5ac8e19190e96cb29d7191d14dbe5/store/src/main/java/org/apache/rocketmq/store/CommitLog.java#L533-L537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyx333 commented on issue #4766: No error message is logged in catch block
Posted by GitBox <gi...@apache.org>.
zyx333 commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1203415058
get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin commented on issue #4766: No error message is logged in catch block
Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1203369470
There is no need to print logs here, because rocketmq master-slave replication is is based on streams rather than messages , so it is common to dispatch half messages. If you print logs here, there will be a lot of dirty logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyx333 commented on issue #4766: No error message is logged in catch block
Posted by GitBox <gi...@apache.org>.
zyx333 commented on issue #4766:
URL: https://github.com/apache/rocketmq/issues/4766#issuecomment-1202422311
#4767 solved in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zyx333 closed issue #4766: No error message is logged in catch block
Posted by GitBox <gi...@apache.org>.
zyx333 closed issue #4766: No error message is logged in catch block
URL: https://github.com/apache/rocketmq/issues/4766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org