[GH] (grails-core/test/artefact-name-precomputation): Workflow run "CI - Groovy Joint Validation Build" failed!

[GitBox <gi...@apache.org>]

The GitHub Actions job "CI - Groovy Joint Validation Build" on grails-core.git/test/artefact-name-precomputation has failed.
Run started by GitHub user borinquenkid (triggered by borinquenkid).

Head commit for run:
bfe84593dd2ab8a1808372781fdbae39363ccaf0 / Walter Duque de Estrada <wb...@mac.com>
Address jdaugherty review feedback on artefact naming characterization spec

Copilot's 5 inline comments claiming the acronym naturalName expectations
were wrong (e.g. 'HTMLC ontroller') are false positives - verified by
running the spec: GrailsNameUtils.getNaturalName genuinely produces those
values, and jdaugherty's review already confirmed this. No change needed
there.

jdaugherty's own feedback was substantive and is addressed here:

- Rename ArtefactNamePrecomputationSpec -> ArtefactNamingContractSpec:
  "precomputed" was aspirational, since nothing in the spec exercises
  actual precomputation, only naming stability.
- Add a comment above the acronym-heavy naturalName assertions explaining
  the quirky-but-intentional GrailsNameUtils splitting behavior they pin,
  so a future reader doesn't "fix" the expectations or the algorithm
  without realizing this spec exists to catch exactly that change.
- Add three cases exercising the artefact detection contract
  (ArtefactHandler#isArtefactClass), which the original spec bypassed
  entirely by constructing GrailsClass wrappers directly: an abstract
  controller is rejected (ControllerArtefactHandler's allowAbstract is
  false), a suffix-matching concrete controller is accepted, and a
  domain-named class with no @Entity/@Artefact annotation is rejected by
  DomainClassArtefactHandler - this is the part a naming precomputation
  refactor is most likely to disturb, and the prior spec gave it no
  coverage at all.

Co-Authored-By: Claude Sonnet 5 <no...@anthropic.com>

Report URL: https://github.com/apache/grails-core/actions/runs/30289954368

With regards,
GitHub Actions via GitBox