You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/07/29 20:52:16 UTC
[GitHub] [beam] reuvenlax opened a new pull request #15247: [BEAM-12686] Expose timer timestamp
reuvenlax opened a new pull request #15247:
URL: https://github.com/apache/beam/pull/15247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890296058
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890291231
run flink validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890378721
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890281027
Run Java Spark PortableValidatesRunner Batch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890226024
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890280985
Run Java Flink PortableValidatesRunner Streaming
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890281071
Run Twister2 ValidatesRunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890291208
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax merged pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax merged pull request #15247:
URL: https://github.com/apache/beam/pull/15247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a change in pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on a change in pull request #15247:
URL: https://github.com/apache/beam/pull/15247#discussion_r680257870
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java
##########
@@ -98,4 +98,11 @@
* the timer fires.
*/
Timer withOutputTimestamp(Instant outputTime);
+
+ /**
+ * Returns the current relative time use by {@link #setRelative()} and {@link #offset}. This can
Review comment:
s/use/used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890280895
run flink validatesrunner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] reuvenlax commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
reuvenlax commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890281002
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #15247: [BEAM-12686] Enable self-managed relative timers
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #15247:
URL: https://github.com/apache/beam/pull/15247#issuecomment-890220483
Is this worth an email to the dev list?
(I'm not sure if this is a corner case or a significant change of behavior)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org