You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@madlib.apache.org by jingyimei <gi...@git.apache.org> on 2017/12/12 06:00:20 UTC

[GitHub] madlib pull request #215: Modify knn help funtion for easier use : JIRA-1187

GitHub user jingyimei opened a pull request:

    https://github.com/apache/madlib/pull/215

    Modify knn help funtion for easier use : JIRA-1187

    This commit does the following:
    1. instead of a `RAISE NOTICE` in udf definition, implement it in a
    plpython so the help message can always get printed out.
    2. add 'example' also as a valid input argument, and make all the input
    arguments ignore upper and lower cases
    3. Add examples in help funtion while there was no examples before

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jingyimei/madlib modify_knn_help_function

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/madlib/pull/215.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #215
    
----
commit d27963368d604f5deb1bbcff34fc413e7722ffc8
Author: Jingyi Mei <jm...@pivotal.io>
Date:   2017-12-12T05:55:19Z

    Modify knn help funtion for easier use : JIRA-1187
    
    This commit does the following:
    1. instead of a `RAISE NOTICE` in udf definition, implement it in a
    plpython so the help message can always get printed out.
    2. add 'example' also as a valid input argument, and make all the input
    arguments ignore upper and lower cases
    3. Add examples in help funtion while there was no examples before

----


---

[GitHub] madlib issue #215: Modify knn help funtion for easier use : JIRA-1187

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit commented on the issue:

    https://github.com/apache/madlib/pull/215
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/306/



---

[GitHub] madlib issue #215: Modify knn help funtion for easier use : JIRA-1187

Posted by iyerr3 <gi...@git.apache.org>.

Github user iyerr3 commented on the issue:

    https://github.com/apache/madlib/pull/215
  
    Is there overlap between this and #213? Maybe consolidate to a single PR? 


---

[GitHub] madlib pull request #215: Modify knn help funtion for easier use : JIRA-1187

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/madlib/pull/215


---