You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Brian Hulette (JIRA)" <ji...@apache.org> on 2019/02/23 02:26:00 UTC

[jira] [Resolved] (ARROW-4580) [JS] Accept Iterables in IntVector/FloatVector from() signatures

     [ https://issues.apache.org/jira/browse/ARROW-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Hulette resolved ARROW-4580.
----------------------------------
    Resolution: Fixed

Closed in https://github.com/apache/arrow/pull/3653


> [JS] Accept Iterables in IntVector/FloatVector from() signatures
> ----------------------------------------------------------------
>
>                 Key: ARROW-4580
>                 URL: https://issues.apache.org/jira/browse/ARROW-4580
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: JavaScript
>    Affects Versions: JS-0.4.0
>            Reporter: Paul Taylor
>            Assignee: Paul Taylor
>            Priority: Major
>             Fix For: JS-0.4.1
>
>
> Right now {{IntVector.from()}} and {{FloatVector.from()}} expect the data is already in typed-array form. But if we know the desired Vector type before hand (e.g. if {{Int32Vector.from()}} is called), we can accept any JS iterable of the values.
> In order to do this, we should ensure {{Float16Vector.from()}} properly clamps incoming f32/f64 values to u16s, in case the source is a vanilla 64-bit JS float.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)