You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/03/23 12:34:40 UTC

[GitHub] [ozone] adoroszlai opened a new pull request, #4457: HDDS-8255. Remove unnecessary sleep at secure container startup

adoroszlai opened a new pull request, #4457:
URL: https://github.com/apache/ozone/pull/4457

   ## What changes were proposed in this pull request?
   
   Get rid of unnecessary 5 seconds sleep at container startup in `ozonesecure-ha` and `ozonesecure-mr` environments, which also caused the following warning:
   
   ```
   ozone.scm.client.address should be set in ozone-site.xml or with the --scm option
   ```
   
   [details](https://issues.apache.org/jira/browse/HDDS-8255?focusedCommentId=17703983&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17703983)
   
   https://issues.apache.org/jira/browse/HDDS-8255
   
   ## How was this patch tested?
   
   Tested locally:
   
   ```
   $ cd hadoop-ozone/dist/target/ozone-1.4.0-SNAPSHOT/compose/ozonesecure-ha
   $ SCM=scm1.org
   $ docker-compose up -d ${SCM}; for i in {1..5}; do docker-compose exec ${SCM} grep scm.service /etc/hadoop/ozone-site.xml; sleep 1; done
   Starting ozonesecure-ha_scm1.org_1 ... done
   <property><name>ozone.scm.service.ids</name><value>scmservice</value></property>
   <property><name>ozone.scm.service.ids</name><value>scmservice</value></property>
   <property><name>ozone.scm.service.ids</name><value>scmservice</value></property>
   <property><name>ozone.scm.service.ids</name><value>scmservice</value></property>
   <property><name>ozone.scm.service.ids</name><value>scmservice</value></property>
   ```
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4498660857
   
   Verified that warning is no longer printed after containers are created:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4498660857/jobs/7915847876#step:5:90
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/4498660857/jobs/7915848282#step:5:644


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai commented on pull request #4457: HDDS-8255. Remove unnecessary sleep at secure container startup

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #4457:
URL: https://github.com/apache/ozone/pull/4457#issuecomment-1481814868

   Thanks @smengcl for reporting the problem and reviewing this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] smengcl commented on pull request #4457: HDDS-8255. Remove unnecessary sleep at secure container startup

Posted by "smengcl (via GitHub)" <gi...@apache.org>.
smengcl commented on PR #4457:
URL: https://github.com/apache/ozone/pull/4457#issuecomment-1482079556

   Thanks @adoroszlai for locating the fixing the issue!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4457: HDDS-8255. Remove unnecessary sleep at secure container startup

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4457:
URL: https://github.com/apache/ozone/pull/4457


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org