[jira] [Updated] (CASSANDRA-21557) Caffeine caches in CompressionDictionaryCache and ZstdDictionaryCompressor should specify an executor explicitly

["Stefan Miklosovic (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CASSANDRA-21557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Miklosovic updated CASSANDRA-21557:
------------------------------------------
     Bug Category: Parent values: Code(13163)
       Complexity: Normal
    Discovered By: Code Inspection
    Fix Version/s: 6.x
         Severity: Normal
         Assignee: Stefan Miklosovic
           Status: Open  (was: Triage Needed)

> Caffeine caches in CompressionDictionaryCache and ZstdDictionaryCompressor should specify an executor explicitly 
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-21557
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-21557
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Feature/Compression
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 6.x
>
>
> We are not setting executor on these caches which means that Caffeine will run stuff like {{removalListener}} on its default executor which is ForkJoinPool.commonPool() which contends with everything else. There is a pattern in Cassandra that each cache sets its own executor so we should do the same. 
> We should use, most probably, ImmediateExecutor.INSTANCE
> https://github.com/ben-manes/caffeine/blob/v3.1.8/caffeine/src/main/java/com/github/benmanes/caffeine/cache/Caffeine.java#L337



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org