You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/27 13:29:21 UTC

[GitHub] rabbah commented on a change in pull request #3225: reduce fillInStackTrace expenses due to ArgNormalizer

rabbah commented on a change in pull request #3225: reduce fillInStackTrace expenses due to ArgNormalizer
URL: https://github.com/apache/incubator-openwhisk/pull/3225#discussion_r164271878
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/DocInfo.scala
 ##########
 @@ -105,6 +105,7 @@ case class BulkEntityResult(id: String,
 }
 
 protected[core] object DocId extends ArgNormalizer[DocId] {
 
 Review comment:
   Does it make sense instead to make constructor public and call it directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services