You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Anand V. Nath" <an...@oracle.com> on 2013/11/05 11:36:55 UTC
[Commit Request] (TRINIDAD-2423) wrong assertion for font-size that
it should be numeric
Hello,
Can someone review and commit the patch uploaded in TRINIDAD-2423?
Thanks
Anand
On 11/5/2013 4:02 PM, Anand V Nath (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/TRINIDAD-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813828#comment-13813828 ]
>
> Anand V Nath commented on TRINIDAD-2423:
> ----------------------------------------
>
> Skinning framework asserts that font-size specified should be always be a number. Otherwise we throw an AssertionError.
>
> font-size can be a non numeric string like [ xx-small | x-small | small | medium | large | x-large | xx-large ]. Thus the assertion is wrong.
>
>> wrong assertion for font-size that it should be numeric
>> -------------------------------------------------------
>>
>> Key: TRINIDAD-2423
>> URL: https://issues.apache.org/jira/browse/TRINIDAD-2423
>> Project: MyFaces Trinidad
>> Issue Type: Bug
>> Components: Skinning
>> Affects Versions: 2.1.0-core
>> Reporter: Anand V Nath
>> Priority: Minor
>>
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1#6144)
Re: [Commit Request] (TRINIDAD-2423) wrong assertion for font-size
that it should be numeric
Posted by jeanne waldman <je...@oracle.com>.
I'll do it.
On 11/5/2013 2:36 AM PT, Anand V. Nath wrote:
> Hello,
>
> Can someone review and commit the patch uploaded in TRINIDAD-2423?
>
> Thanks
> Anand
> On 11/5/2013 4:02 PM, Anand V Nath (JIRA) wrote:
>> [ https://issues.apache.org/jira/browse/TRINIDAD-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813828#comment-13813828 ]
>>
>> Anand V Nath commented on TRINIDAD-2423:
>> ----------------------------------------
>>
>> Skinning framework asserts that font-size specified should be always be a number. Otherwise we throw an AssertionError.
>>
>> font-size can be a non numeric string like [ xx-small | x-small | small | medium | large | x-large | xx-large ]. Thus the assertion is wrong.
>>
>>> wrong assertion for font-size that it should be numeric
>>> -------------------------------------------------------
>>>
>>> Key: TRINIDAD-2423
>>> URL: https://issues.apache.org/jira/browse/TRINIDAD-2423
>>> Project: MyFaces Trinidad
>>> Issue Type: Bug
>>> Components: Skinning
>>> Affects Versions: 2.1.0-core
>>> Reporter: Anand V Nath
>>> Priority: Minor
>>>
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.1#6144)
>