You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2012/11/28 15:02:57 UTC
[jira] [Created] (JCR-3469) Thread interrupt may result in closed
index files
Marcel Reutegger created JCR-3469:
-------------------------------------
Summary: Thread interrupt may result in closed index files
Key: JCR-3469
URL: https://issues.apache.org/jira/browse/JCR-3469
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-core
Affects Versions: 2.4
Reporter: Marcel Reutegger
Priority: Minor
Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508652#comment-13508652 ]
Marcel Reutegger commented on JCR-3469:
---------------------------------------
Looks like this is solaris specific. More background information is available here: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4385444
On Solaris the HotSpot option UseVMInterruptibleIO is enabled per default with Java 6. This makes I/O behaviour in presence of Thread interrupts platform specific. I'll try to reproduce the test failure on a Solaris instance...
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 2.6
>
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508608#comment-13508608 ]
Marcel Reutegger commented on JCR-3469:
---------------------------------------
Disabled test for now in revision: 1416387
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 2.6
>
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505620#comment-13505620 ]
Alex Parvulescu commented on JCR-3469:
--------------------------------------
> Please note the test will only fail on non-Windows platforms without configuration changes
Can we leverage the lucene Constants.WINDOWS constant to simply skip the test on windows?
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506329#comment-13506329 ]
Marcel Reutegger commented on JCR-3469:
---------------------------------------
I considered extending from an abstract test class as well, but then noticed
that I'd have to change the test repository.xml as well to use the SimpleFSDirectory
for the version storage index. I decided to keep the existing test configuration
as is because the automatic FSDirectory resolution is still the default.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-3469:
----------------------------------
Attachment: JCR-3469-test.patch
Attached patch contains a test reproducing the issue.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Parvulescu resolved JCR-3469.
----------------------------------
Resolution: Fixed
Fix Version/s: 2.6
applied the patch with revision 1415093.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Fix For: 2.6
>
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505643#comment-13505643 ]
Alex Parvulescu commented on JCR-3469:
--------------------------------------
One more tiny suggestion :)
Wouldn't it be easier to extend from AbstractIndexingTest and just switch the flag on before the test and back to its original value after?
This way the test would have its own dedicated workspace, just like the indexing config test we already have.
Would that make the test simpler?
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger resolved JCR-3469.
-----------------------------------
Resolution: Fixed
I'm able to reproduce this on Solaris 11.1 (x86). In contrast to NIO, the underlying file is not closed and subsequent queries are successful.
Updated the test to ignore the RepositoryException if the root cause is a InterruptedIOException.
svn revision 1416863
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 2.6
>
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-3469:
----------------------------------
Attachment: JCR-3469.patch
Good point. Thanks for the suggestion.
Attached patch now contains both an updated test and changes to support a new 'useSimpleFSDirectory' param.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505577#comment-13505577 ]
Marcel Reutegger commented on JCR-3469:
---------------------------------------
Please note the test will only fail on non-Windows platforms without configuration changes. On Windows the FSDirectory factory method already picks the SimpleFSDirectory automatically.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger reopened JCR-3469:
-----------------------------------
Assignee: Marcel Reutegger
Test fails on Apache Jenkins.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Fix For: 2.6
>
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Marcel Reutegger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Reutegger updated JCR-3469:
----------------------------------
Attachment: JCR-3469.patch
This patch adds a parameter to the SearchIndex and allows you to switch back to the SimpleFSDirectory.
The previous test runs successfully when SimpleFSDirectory is enabled.
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-3469) Thread interrupt may result in closed
index files
Posted by "Alex Parvulescu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-3469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505667#comment-13505667 ]
Alex Parvulescu commented on JCR-3469:
--------------------------------------
ok, it seems that a dedicated workspace would not suffice, as the original problem still touches the default ws.
+1 for the patch
> Thread interrupt may result in closed index files
> -------------------------------------------------
>
> Key: JCR-3469
> URL: https://issues.apache.org/jira/browse/JCR-3469
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-core
> Affects Versions: 2.4
> Reporter: Marcel Reutegger
> Priority: Minor
> Attachments: JCR-3469.patch, JCR-3469.patch, JCR-3469-test.patch
>
>
> Interrupting a thread, which is currently performing I/O on Lucene index files, may result in closed index files. Jackrabbit versions prior to 2.4 didn't have that problem because only with the update of Lucene to 3.0.3 in Jackrabbit 2.4 the underlying default for the FSDirectory in Lucene changed from SimpleFSDirectory to NIOFSDirectory. The latter uses a FileChannel to perform concurrent read operations on a single channel, but because of the way how FileChannel is specified an interrupt will result in the FileChannel to be closed.
> This was also discussed on the Lucene mailing list. See: http://lucene.markmail.org/thread/ea7mj2kpdvyuesss
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira