[GitHub] [superset] eschutho commented on a change in pull request #12694: chore: add required review on master

[GitBox <gi...@apache.org>]

eschutho commented on a change in pull request #12694:
URL: https://github.com/apache/superset/pull/12694#discussion_r562933918



##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - lint
+          - test-mysql
+          - test-postgres
+          - test-sqlite
+
+      required_pull_request_reviews:
+        dismiss_stale_reviews: true
+        require_code_owner_reviews: true
+        required_approving_review_count: 1

Review comment:
       definitely would like a second pair of eyes on all this. 

##########
File path: .asf.yaml
##########
@@ -52,3 +52,24 @@ github:
     squash: true
     merge: false
     rebase: false
+
+  protected_branches:
+    master:
+      required_status_checks:
+        # strict means "Require branches to be up to date before merging".
+        strict: false
+        # contexts are the names of checks that must pass
+        contexts:
+          - Docker/build
+          - Frontend/build
+          - PR Lint/check
+          - E2E/Cypress
+          - lint
+          - test-mysql
+          - test-postgres
+          - test-sqlite
+
+      required_pull_request_reviews:
+        dismiss_stale_reviews: true
+        require_code_owner_reviews: true
+        required_approving_review_count: 1

Review comment:
       definitely would like a second pair of eyes on all this. I don't think there's a way to test before merging.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org