You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Yurii Shylov <yu...@gmail.com> on 2015/01/21 19:27:37 UTC
Review Request 30133: API does not allow Repo URL to be changed if
the repo version is current
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-9242
https://issues.apache.org/jira/browse/AMBARI-9242
Repository: ambari
Description
-------
API disallows Repo URLs from being edited if the version is current.
We allow this in 1.7.0 and is a regression.
We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
It is allowed always to change display_name.
It is possible to change upgrade_pack if it is not installed on any of the clusters.
It is possible to always change base URLs.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
Diff: https://reviews.apache.org/r/30133/diff/
Testing
-------
In progress
Thanks,
Yurii Shylov
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/#review69157
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 21, 2015, 1:27 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30133/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 1:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9242
> https://issues.apache.org/jira/browse/AMBARI-9242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API disallows Repo URLs from being edited if the version is current.
> We allow this in 1.7.0 and is a regression.
> We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
>
> It is allowed always to change display_name.
> It is possible to change upgrade_pack if it is not installed on any of the clusters.
> It is possible to always change base URLs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
>
> Diff: https://reviews.apache.org/r/30133/diff/
>
>
> Testing
> -------
>
> In progress
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/#review69219
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Jan. 22, 2015, 6:21 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30133/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 6:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9242
> https://issues.apache.org/jira/browse/AMBARI-9242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API disallows Repo URLs from being edited if the version is current.
> We allow this in 1.7.0 and is a regression.
> We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
>
> It is allowed always to change display_name.
> It is possible to change upgrade_pack if it is not installed on any of the clusters.
> It is possible to always change base URLs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
>
> Diff: https://reviews.apache.org/r/30133/diff/
>
>
> Testing
> -------
>
> Tests ok
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/#review69226
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 22, 2015, 6:21 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30133/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 6:21 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9242
> https://issues.apache.org/jira/browse/AMBARI-9242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API disallows Repo URLs from being edited if the version is current.
> We allow this in 1.7.0 and is a regression.
> We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
>
> It is allowed always to change display_name.
> It is possible to change upgrade_pack if it is not installed on any of the clusters.
> It is possible to always change base URLs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
>
> Diff: https://reviews.apache.org/r/30133/diff/
>
>
> Testing
> -------
>
> Tests ok
>
>
> Thanks,
>
> Yurii Shylov
>
>
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/
-----------------------------------------------------------
(Updated Янв. 22, 2015, 6:21 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Bugs: AMBARI-9242
https://issues.apache.org/jira/browse/AMBARI-9242
Repository: ambari
Description
-------
API disallows Repo URLs from being edited if the version is current.
We allow this in 1.7.0 and is a regression.
We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
It is allowed always to change display_name.
It is possible to change upgrade_pack if it is not installed on any of the clusters.
It is possible to always change base URLs.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
Diff: https://reviews.apache.org/r/30133/diff/
Testing (updated)
-------
Tests ok
Thanks,
Yurii Shylov
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Yurii Shylov <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/
-----------------------------------------------------------
(Updated Янв. 22, 2015, 6:20 п.п.)
Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
Changes
-------
Fixed failing UT
Bugs: AMBARI-9242
https://issues.apache.org/jira/browse/AMBARI-9242
Repository: ambari
Description
-------
API disallows Repo URLs from being edited if the version is current.
We allow this in 1.7.0 and is a regression.
We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
It is allowed always to change display_name.
It is possible to change upgrade_pack if it is not installed on any of the clusters.
It is possible to always change base URLs.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
Diff: https://reviews.apache.org/r/30133/diff/
Testing
-------
In progress
Thanks,
Yurii Shylov
Re: Review Request 30133: API does not allow Repo URL to be changed
if the repo version is current
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30133/#review69152
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 21, 2015, 6:27 p.m., Yurii Shylov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30133/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2015, 6:27 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and Nate Cole.
>
>
> Bugs: AMBARI-9242
> https://issues.apache.org/jira/browse/AMBARI-9242
>
>
> Repository: ambari
>
>
> Description
> -------
>
> API disallows Repo URLs from being edited if the version is current.
> We allow this in 1.7.0 and is a regression.
> We'll not be able to accommodate the case if the repo URL changes (say one local mirror server to another, or from public URL to local mirror, etc).
>
> It is allowed always to change display_name.
> It is possible to change upgrade_pack if it is not installed on any of the clusters.
> It is possible to always change base URLs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java a463439
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java 17fa2c2
>
> Diff: https://reviews.apache.org/r/30133/diff/
>
>
> Testing
> -------
>
> In progress
>
>
> Thanks,
>
> Yurii Shylov
>
>