You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/10 07:45:14 UTC

[GitHub] [camel-k] astefanutti commented on a change in pull request #1850: fix(trait): bool trait props should be pointer, otherwise omitted in CR #1848

astefanutti commented on a change in pull request #1850:
URL: https://github.com/apache/camel-k/pull/1850#discussion_r539941718



##########
File path: pkg/trait/trait_types.go
##########
@@ -188,6 +188,22 @@ type ControllerStrategySelector interface {
 	ControllerStrategySelectorOrder() int
 }
 
+func isTrue(b *bool) bool {

Review comment:
       I'd suggest to move these methods into the `util.go` file.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org