You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "anchovYu (via GitHub)" <gi...@apache.org> on 2023/02/01 07:42:17 UTC

[GitHub] [spark] anchovYu commented on pull request #39773: [SPARK-42217][SQL] Support implicit lateral column alias in queries with Window

anchovYu commented on PR #39773:
URL: https://github.com/apache/spark/pull/39773#issuecomment-1411595045

   @srielau Thanks for bringing up this concern. 
   LCA in this PR doesn't introduce nested Window, it is a feature already been supported by Spark. But LCA does make this pattern easier to access.
   
   I suggest to merge this PR first, but further iterate on if we want to control the default behavior using a config, or if we want to partially forbid it. I believe basic support in Window is still needed anyway, e.g. select 1 as a, a, ..(followed by some  regular window expression), which is enabled by this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org