You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by vasia <gi...@git.apache.org> on 2015/10/16 18:13:34 UTC
[GitHub] flink pull request: [FLINK-2857] [gelly] API improvements
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1263
[FLINK-2857] [gelly] API improvements
This PR:
- renames the mapper parameter in creation methods to `vertexInitializer`, so that its purpose is easier to understand.
- add `fromTuple2DataSet` methods to easily create graphs from `Tuple2` datasets, i.e. edges with no values.
- replaces the mapper UDFs in the `joinWith*` with `VertexJoinFunction` and `EdgeJoinFunction`. These have flattened parameters and their purpose is more intuitive.
- improves the java/scala docs of several methods.
- updates docs accordingly.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vasia/flink flink-2857
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1263
----
commit c1ddbf032d492fd5c9d937ec3bcf8c89d96a5c0f
Author: vasia <va...@apache.org>
Date: 2015-10-16T09:11:40Z
[FLINK-2857] [gelly] improve javadocs of Graph creation methods; add fromTuple2 creation methods;
rename mapper parameters to vertexInitializer.
commit 59d6eece651c7edff166de48a5485752353c0238
Author: vasia <va...@apache.org>
Date: 2015-10-16T14:44:14Z
[FLINK-2857] [gelly] improve javadocs and parameter names of joinWith* methods
commit edb7384837dc640f61d53454df7ff6c01efb1634
Author: vasia <va...@apache.org>
Date: 2015-10-16T15:45:50Z
[FLINK-2857] [gelly] improve javadocs of neighborhood methods
commit e23a92dc23329737ae5a7aed7423e6fd5493db2a
Author: vasia <va...@apache.org>
Date: 2015-10-16T16:05:08Z
[FLINK-2857] [gelly] [docs] update docs to reflect api changes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2857] [gelly] API improvements
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1263#discussion_r42366708
--- Diff: docs/libs/gelly_guide.md ---
@@ -424,8 +448,8 @@ graph.subgraph((vertex => vertex.getValue > 0), (edge => edge.getValue < 0))
<img alt="Filter Transformations" width="80%" src="fig/gelly-filter.png"/>
</p>
-* <strong>Join</strong>: Gelly provides specialized methods for joining the vertex and edge datasets with other input datasets. `joinWithVertices` joins the vertices with a `Tuple2` input data set. The join is performed using the vertex ID and the first field of the `Tuple2` input as the join keys. The method returns a new `Graph` where the vertex values have been updated according to a provided user-defined map function.
-Similarly, an input dataset can be joined with the edges, using one of three methods. `joinWithEdges` expects an input `DataSet` of `Tuple3` and joins on the composite key of both source and target vertex IDs. `joinWithEdgesOnSource` expects a `DataSet` of `Tuple2` and joins on the source key of the edges and the first attribute of the input dataset and `joinWithEdgesOnTarget` expects a `DataSet` of `Tuple2` and joins on the target key of the edges and the first attribute of the input dataset. All three methods apply a map function on the edge and the input data set values.
+* <strong>Join</strong>: Gelly provides specialized methods for joining the vertex and edge datasets with other input datasets. `joinWithVertices` joins the vertices with a `Tuple2` input data set. The join is performed using the vertex ID and the first field of the `Tuple2` input as the join keys. The method returns a new `Graph` where the vertex values have been updated according to a provided user-defined tranformation function.
--- End diff --
tranSformation function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2857] [gelly] API improvements
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1263#issuecomment-149219197
Thank you Fabian :))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2857] [gelly] API improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1263
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2857] [gelly] API improvements
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1263#issuecomment-149210731
Looks good to me. Will fix the typo and merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---